Skip to content

Add Package Maintenance WG #3397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 9, 2020
Merged

Conversation

rxmarbles
Copy link
Contributor

@rxmarbles rxmarbles commented Sep 24, 2020

As of this PR nodejs/TSC#880 the package maintenance WG has been chartered. We would like to add the WG to the NodeJS website

@Trott
Copy link
Member

Trott commented Sep 26, 2020

It's possible that listing goals is better than listing responsibilities--I haven't thought about that--but all the other entries list the responsibilities, and those are listed in nodejs/TSC#880. So maybe that's what should be here rather goals?

@Trott
Copy link
Member

Trott commented Sep 26, 2020

Thanks for doing this. I have comments above, but nothing blocking it landing if others review it.

@Trott
Copy link
Member

Trott commented Sep 26, 2020

/ping @nodejs/website This could use reviews.

@rxmarbles
Copy link
Contributor Author

It's possible that listing goals is better than listing responsibilities--I haven't thought about that--but all the other entries list the responsibilities, and those are listed in nodejs/TSC#880. So maybe that's what should be here rather goals?

Good catch on the responsibilities I missed that PR. Seems it needs a fix though as the package maintenance wg isn't listed in the list of WG's I'll get that updated as well in a fast follow

@rxmarbles rxmarbles requested a review from Trott September 27, 2020 06:46
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rxmarbles rxmarbles requested a review from nschonni September 29, 2020 01:42
@rxmarbles
Copy link
Contributor Author

@nschonni @aymen94 @mhdawson can we merge this PR? seems it has a decent amount of approvals. Plus I don't want to keep merging from master 😜

@Trott
Copy link
Member

Trott commented Oct 9, 2020

Might be nice to add a sentence explaining what the working group's function is, like the other ones have, but that can happen in a subsequent PR, or not at all. LGTM. Landing.

@Trott Trott merged commit 20f75b2 into nodejs:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants