Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blog: add attribution #3385

Merged
merged 2 commits into from
Sep 18, 2020
Merged

blog: add attribution #3385

merged 2 commits into from
Sep 18, 2020

Conversation

mhdawson
Copy link
Member

Signed-off-by: Michael Dawson mdawson@devrus.com

Signed-off-by: Michael Dawson <mdawson@devrus.com>
@ashi009
Copy link

ashi009 commented Sep 18, 2020

There is a typo on line 33.

fs.realpath.native on may

Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins MylesBorins merged commit 5454754 into nodejs:master Sep 18, 2020
@MylesBorins
Copy link
Contributor

MylesBorins commented Sep 18, 2020

@ashi009 as this change was related to giving credit to someone and unrelated to fixing a spelling error I left that unfixed. It would likely be a good idea to fix that in a follow up PR

edit: --> #3386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants