Banner: add link to Unhandled Rejections survey #3336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're seeking input from the community on the longstanding unhandled rejections deprecation. The survey will run for ~2 weeks Ref: nodejs/TSC#902
Contributor
Author
|
@nodejs/website pinging since this is time-sensitive. Also cc @nodejs/tsc for awareness |
Contributor
Author
|
Happy to hear suggestions for the text. An alternative I've considered was |
codebytere
approved these changes
Aug 12, 2020
lpinca
approved these changes
Aug 12, 2020
evanlucas
approved these changes
Aug 12, 2020
Contributor
|
Based on multiple reviews and time sensitivity I'm going to land this, if we want to bikeshed text lets open another PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're seeking input from the community on the longstanding unhandled
rejections deprecation. The survey will run for ~2 weeks
Ref: nodejs/TSC#902