fix: no-shortcut-reference-link#2697
Conversation
|
@nschonni can you fix tests and take care of my comment above? |
MylesBorins
left a comment
MylesBorins
left a comment
There was a problem hiding this comment.
The changelogs are generated from the upstream changelog in the repo itself. I'm not 100% that we should be changing them for a linting rule
Since we're importing them from elsewhere, it may be best to simply skip linting on them entirely and enforce any lint rules we want upstream (or just don't worry about the linting for the changelogs). |
nschonni
force-pushed
the
fix--no-shortcut-reference-link
branch
3 times, most recently
from
bb32b11 to
37e923f
Compare
|
Although a bunch of the changelog related fixes have been applied upstream, i've just disabled the same rules plus this new one at the file level for the changlog blogs |
nschonni
force-pushed
the
fix--no-shortcut-reference-link
branch
from
37e923f to
3ebf376
Compare
locale/en/blog/release/v0.10.42.md
Outdated
There was a problem hiding this comment.
Can you confirm such comments are not in the built HTML? Not a blocker, but we should be aware about it.
There was a problem hiding this comment.
Yes, it looks like it ends up the built HTML
There was a problem hiding this comment.
This is Chinese to me so I can't judge the change 😛
|
LGTM now, it needs a rebase and I left a couple of comments. I can approve after those are addressed 🙂 |
nschonni
force-pushed
the
fix--no-shortcut-reference-link
branch
from
3ebf376 to
7c4f3b1
Compare
|
Rebased. Confirmed that the |
4 participants
No description provided.