Merged
Conversation
Manually reviewed since casing is intended for emails and some urls.
Member
|
@nodejs/website |
nickserv
approved these changes
Oct 9, 2019
tniessen
approved these changes
Oct 9, 2019
3imed-jaberi
approved these changes
Oct 10, 2019
locale/en/knowledge/getting-started/control-flow/how-to-write-asynchronous-code.md
Outdated
Show resolved
Hide resolved
locale/en/knowledge/getting-started/how-to-debug-nodejs-applications.md
Outdated
Show resolved
Hide resolved
locale/en/knowledge/getting-started/control-flow/how-to-write-asynchronous-code.md
Outdated
Show resolved
Hide resolved
locale/en/knowledge/getting-started/control-flow/what-are-callbacks.md
Outdated
Show resolved
Hide resolved
Trott
previously requested changes
Oct 10, 2019
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Some changes needed per comments. (Not sure about all of them, but some of them are definitely required.) Feel free to dismiss this "request changes" review once changes have been applied.
Co-Authored-By: Aissaoui Ahmed <Aissaoui-Ahmed@users.noreply.github.com>
stevemao
approved these changes
Oct 10, 2019
osk2
approved these changes
Oct 10, 2019
aymen94
approved these changes
Oct 10, 2019
XhmikosR
approved these changes
Oct 10, 2019
Contributor
|
BTW I wouldn't remove the double spaces after a period in this PR. It seems it is in many places; I believe some people prefer writing like that. Personally I don't agree with that, but still, it should be done in a separate PR and tackle all of the instances. |
This was referenced Oct 10, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manually reviewed since casing is intended for emails and some urls.