-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display LTS and Stable on the frontpage #260
Conversation
<a href="https://nodejs.org/dist/{{ project.currentVersion }}/" id="home-downloadbutton" data-version="{{ project.currentVersion }}" data-dl-local="{{ labels.download-for }}">{{ labels.download }}</a> | ||
<h2 id="home-downloadhead" data-dl-local="{{ labels.download-for }}">{{ labels.download }}</h2> | ||
|
||
<a href="https://nodejs.org/dist/{{ project.currentVersions.lts }}/" class="home-downloadbutton" title="Download {{ project.currentVersions.lts }} LTS" data-version="{{ project.currentVersions.lts }}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Texts need to be fully translatable, even "LTS" might need to be translated as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
f961908
to
aedcaf9
Compare
Just too clarify, this can be merged now rather than syncing with the release of v5.0.0. It was made that way intentionally as I noticed @rvagg commented (somewhere?) that whenever a new release got promoted to http://nodejs.org/dist, it automatically kicked of a rebuild of the website. |
+1, a solid job and indicates that LTS is important, too. |
I think it would be valueable for us to track clicks on these links. Any chance I could access to the GA stats for nodejs.org @mikeal? |
I'd like to see a simple explanation of LTS if we're to introduce both buttons. "What should I download" |
@jbergstroem would a couple of keywords like shown in #200 comment suffice? |
Will display two release lines on the frontpage, as soon as https://nodejs.org/dist/index.json contains a v5.0.0 release which is not marked as `lts`. Until v5.0.0 exists in index.json, only v4.x LTS will be displayed.
aedcaf9
to
3b7bae8
Compare
In response to @jbergstroem and other similar comments in #200, I just pushed an update with @rvagg suggested taglines. v4.2.1 only (before v5 exists)v4.2.1 and v5 |
+1 let's queue this up, aiming for a v5 release tomorrow, if that slips then next Monday or Tuesday at the latest |
Merged: e53ddb3. I changed the wording from "Other LTS Downloads/Stable" to "Other Downloads: LTS/Stable". |
Nice @fhemberger 👍 |
Until v5.0.0 exists in https://nodejs.org/dist/index.json, only v4.x LTS will be displayed, in other words just as before besides some design changes:
Will display two buttons side by side automagically, as soon as
index.json
contains a v5.0.0 release which is not marked aslts
:Any thoughts?
Refs #200.