Skip to content

fix: Unescape backtick #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2019
Merged

fix: Unescape backtick #2492

merged 1 commit into from
Sep 5, 2019

Conversation

nschonni
Copy link
Member

@nschonni nschonni commented Sep 4, 2019

No description provided.

@XhmikosR
Copy link
Contributor

XhmikosR commented Sep 4, 2019

There are a few more cases like this, for \_ when inside code. I've been meaning to search the docs about it but I forget.

@XhmikosR
Copy link
Contributor

XhmikosR commented Sep 4, 2019

For example FIXED\_ONE\_BYTE\_STRING. We need a regex for this so that we find all these instances.

@XhmikosR
Copy link
Contributor

XhmikosR commented Sep 4, 2019

Alright, I figured this out. I'm gonna make a PR and we review it thoroughly.

@XhmikosR XhmikosR mentioned this pull request Sep 4, 2019
Merged
@SEWeiTung SEWeiTung merged commit bd66501 into nodejs:master Sep 5, 2019
@nschonni nschonni deleted the fix--Unescape-backtick branch September 5, 2019 01:39
@snyk-bot snyk-bot mentioned this pull request Jul 15, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XhmikosR XhmikosR XhmikosR approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nschonni @XhmikosR @Trott @SEWeiTung