Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ja: Update security translation #2197

Merged
2 commits merged into from
Apr 20, 2019
Merged

ja: Update security translation #2197

2 commits merged into from
Apr 20, 2019

Conversation

e-jigsaw
Copy link
Contributor

ref: #2179

@e-jigsaw
Copy link
Contributor Author

@nodejs/nodejs-ja Review plz!

(全体的に古くなっていたので書き換えました)

okuryu
okuryu reviewed Apr 18, 2019
View reviewed changes
locale/ja/security.md Outdated Show resolved Hide resolved
okuryu
okuryu reviewed Apr 18, 2019
View reviewed changes
locale/ja/security.md Outdated Show resolved Hide resolved
update
74c8365 
remove useless symbols
@ghost
Copy link

ghost commented Apr 19, 2019

@nodejs/nodejs-ja：Any other clues or review suggestions?

okuryu
okuryu approved these changes Apr 19, 2019
View reviewed changes
Copy link
Contributor

@okuryu okuryu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me.

@Maledong thanks for your helps.

@ghost ghost merged commit 9dd5f0e into nodejs:master Apr 20, 2019
@e-jigsaw e-jigsaw deleted the e-jigsaw-patch-1 branch April 21, 2019 04:50
@e-jigsaw
Copy link
Contributor Author

Thanks!

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okuryu okuryu okuryu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-jigsaw @okuryu