Fix typo in about/index.md AR #2062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested a review
from 
fhemberger
suggested changes
Feb 11, 2019
locale/ar/about/index.md
Outdated
| @@ -38,7 +38,7 @@ server.listen(port, hostname, () => { | |||
| تأخذ النود جي اس موديل الاحداث (event model) ابعد قليلا فتمثل الحلقة التكرارية الخاصة بالاحداث ([event loop][]) كمكون اساسي في وقت التشغيل (runtime construct) وليس كمكتبة في انظمة أخرى، حيث ان هنالك دائما استدعاء متزامن (blocking call) | |||
| للبدء في حلقة الاحداث. | |||
| مبدئيا، يتم تحديد السلوك عبر دالة مستدعاة في بداية السكريبت في نهايتها | |||
| تقوم بتشغيل خادم (server) عبر استدعاءٍ غير متزامن (blocking call) مثل <span dir="ltr">`EventMachine::run()`</span>، ولكن في النود جي اس لا يوجد شيء من هذا القبيل. | |||
| تقوم بتشغيل خادم (server) عبر استدعاءٍ غير متزامن (non-blocking call) مثل <span dir="ltr">`EventMachine::run()`</span>، ولكن في النود جي اس لا يوجد شيء من هذا القبيل. | |||
There was a problem hiding this comment.
blocking is correct here, see https://nodejs.org/en/about/:
Typically behavior is defined through callbacks at the beginning of a script and at the end starts a server through a blocking call like
EventMachine::run(). In Node there is no such start-the-event-loop call.
There was a problem hiding this comment.
ok, Corrected the mistake.
@fhemberger
|
@celyes：You don't need to close it if you had a force push and fixed it, this could be also merged if possible :) |
|
@Maledong : thank you, but it's basically blank lines, so i don't think it deserves to be merged IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the term "blocking call" to "non-blocking call" in
about/index.md:41@Aissaoui-Ahmed @InterstellarClub