Skip to content

Revert changes to non-English text in locale/en/get-involved/events.md #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2017

Conversation

bf4
Copy link
Contributor

@bf4 bf4 commented Feb 9, 2017

As noted in #1128, there was non-English that was erroneously
modified in #1130

I retained the following changes to the file:

diff --git a/locale/en/get-involved/events.md b/locale/en/get-involved/events.md
index efca106..72c52f4 100644
--- a/locale/en/get-involved/events.md
+++ b/locale/en/get-involved/events.md
@@ -60,7 +60,7 @@ regions:
         city: Casablanca
         link: 'http://www.meetup.com/Meteor-Casablanca/'
         name: Meteor Casablanca
-        description: "<p>a community gathering Meteor enthusiasts and passionate developpers to share knowledge in an inspiring way.</p>\n<p>Meteor is an open-source platform for building top-quality web apps in a fraction of the time, whether you're an expert developer or just getting started.</p>\n<br>\n\nBuilding web application is hard and time consuming and often an intimidating process , it was the right time to invent a new way to aproach building application by hiding irrelevant complexity and focus more on the core of the product. we believe this new aproach is championned by Meteor , and this deserves \_regular celebration \_meetings during which people can share their passion , in a human friendly way .<br>\n\nand also build things that can grow to be exciting !!\n<p><br>\n\n</p>"
+        description: "<p>a community gathering Meteor enthusiasts and passionate developers to share knowledge in an inspiring way.</p>\n<p>Meteor is an open-source platform for building top-quality web apps in a fraction of the time, whether you're an expert developer or just getting started.</p>\n<br>\n\nBuilding web application is hard and time consuming and often an intimidating process , it was the right time to invent a new way to aproach building application by hiding irrelevant complexity and focus more on the core of the product. we believe this new aproach is championned by Meteor , and this deserves \_regular celebration \_meetings during which people can share their passion , in a human friendly way .<br>\n\nand also build things that can grow to be exciting !!\n<p><br>\n\n</p>"
         lon: -7.579999923706055
         group_photo:
           photo_link: 'http://photos2.meetupstatic.com/photos/event/d/3/b/0/600_432774192.jpeg'

typo developpers

@@ -2048,7 +2048,7 @@ regions:
         city: London
         link: 'http://www.meetup.com/londondigital/'
         name: London Digital Design and Technology User Group
-        description: "<p>The London Design and technology user group is here to offer varied content for both designer and developers who live breath and work in the digital development space.</p>\n<p>This group is for the people who 'make' web experiences apps and games. Mainly it will be\_focussed\_on design and technology but we will also host any talks that are presented from a perspective that will be interesting to the members, so whether it be business related or strategic it will always be relevent.</p>\n<p>\_</p>"
+        description: "<p>The London Design and technology user group is here to offer varied content for both designer and developers who live breath and work in the digital development space.</p>\n<p>This group is for the people who 'make' web experiences apps and games. Mainly it will be\_focussed\_on design and technology but we will also host any talks that are presented from a perspective that will be interesting to the members, so whether it be business related or strategic it will always be relevant.</p>\n<p>\_</p>"
         lon: -0.10000000149011612
         lat: 51.52000045776367
       - country: GB

typo relevent

@@ -3207,7 +3207,7 @@ regions:
         city: Berlin
         link: 'http://www.meetup.com/Berlin-Grill-JS-Meetup/'
         name: Berlin Grill.JS Meetup
-        description: "<p>Summer is here, so let's get together around the grill, have a few beers and wursts, and enjoy a lush evening on the summer terrace. The Grill.JS Meetup is strictly informal. There won't be official tech presentations, it's all about friendly discussions over a beer and a grillwurst. We do welcome lightning talks, and we're sure attendees would love to listen to \"my dumbest JS idea this year \". Just keep it short and entertaining. We'll provide for drinks (beer, mate, non-alcoholic) and grillwurst and some vegetarion options, and some salad. If you have special requirements, please bring your own food or drinks.</p>"
+        description: "<p>Summer is here, so let's get together around the grill, have a few beers and wursts, and enjoy a lush evening on the summer terrace. The Grill.JS Meetup is strictly informal. There won't be official tech presentations, it's all about friendly discussions over a beer and a grillwurst. We do welcome lightning talks, and we're sure attendees would love to listen to \"my dumbest JS idea this year \". Just keep it short and entertaining. We'll provide for drinks (beer, mate, non-alcoholic) and grillwurst and some vegetarian options, and some salad. If you have special requirements, please bring your own food or drinks.</p>"
         lon: 13.380000114440918
         lat: 52.52000045776367
       - country: GB

typo vegetarion

@@ -3523,7 +3523,7 @@ regions:
         city: Berlin
         link: 'http://www.meetup.com/fullstack-js-berlin/'
         name: Fullstack.js
-        description: "<p>This user group is about anything related to JavaScript and web development with a focus to modularity and scalability. We're also open for topics on infrasturcture.</p>"
+        description: "<p>This user group is about anything related to JavaScript and web development with a focus to modularity and scalability. We're also open for topics on infrastructure.</p>"
         lon: 13.380000114440918
         group_photo:
           photo_link: 'http://photos2.meetupstatic.com/photos/event/1/a/0/6/600_421566662.jpeg'

typo infrasturcture

@@ -4813,7 +4813,7 @@ regions:
         link: 'http://www.meetup.com/lubunode/'
         name: Ludwigsburg Node.js Meetup
         description: |-
-          <p>Let's discuss all things node! Whether it be ES6 features for JavaScript, npm packages, continous integration or anything else. The complete node ecosystem is ready to be explored :)</p>
+          <p>Let's discuss all things node! Whether it be ES6 features for JavaScript, npm packages, continuous integration or anything else. The complete node ecosystem is ready to be explored :)</p>
           <p><span>We'll start off with monthly meetups at selected pubs in Ludwigsburg until we get a decent group of regulars to organize bigger events with dedicated locations and speakers. Everyone interested in programming is welcome to join us!</span></p>
         lon: 9.1899995803833
         lat: 48.900001525878906

typo continous

@@ -6045,7 +6045,7 @@ regions:
         city: Matamoros
         link: 'http://www.meetup.com/RGV-bots/'
         name: RGV bots
-        description: 'This is a group for anyone interested in Hardware-Software Technologies Integration, mainly focused in OpenSource movment. All skills levels are welcome.'
+        description: 'This is a group for anyone interested in Hardware-Software Technologies Integration, mainly focused in OpenSource movement. All skills levels are welcome.'
         lon: -97.5
         lat: 25.8799991607666
       - country: AR

typo movment

@@ -11675,7 +11675,7 @@ regions:
         city: Boulder
         link: 'http://www.meetup.com/bouldernode/'
         name: Boulder Node.js
-        description: "<p>Attn Node.js afficionados: This is one technology group that will get you publishing NPM's, collaborate on open-source projects together, and discuss hosting needs among more novel uses of the technology. When solutions don't exist, we'll build them. Come to share your ideas and learn in interactive workshops. Mentor others and find mentees. If you don't know how to code, come with an attitude to learn.</p>"
+        description: "<p>Attn Node.js aficionados: This is one technology group that will get you publishing NPM's, collaborate on open-source projects together, and discuss hosting needs among more novel uses of the technology. When solutions don't exist, we'll build them. Come to share your ideas and learn in interactive workshops. Mentor others and find mentees. If you don't know how to code, come with an attitude to learn.</p>"
         lon: -105.27999877929688
         lat: 40.040000915527344
       - country: US

typo afficionados

@@ -12509,7 +12509,7 @@ regions:
         city: Brisbane
         link: 'http://www.meetup.com/Brisbane-AppDynamics/'
         name: Brisbane AppDynamics User Group
-        description: "<p>AppDynamics! Where Application Perfomance meets DevOps. The hottest APM company on the planet. Find out what's new from the local AppDynamics team, discuss trends in APM technology, and share stories with other like-minded AppDynamos.</p>"
+        description: "<p>AppDynamics! Where Application Performance meets DevOps. The hottest APM company on the planet. Find out what's new from the local AppDynamics team, discuss trends in APM technology, and share stories with other like-minded AppDynamos.</p>"
         lon: 153.02000427246094
         lat: -27.459999084472656
       - country: AU

typo Perfomance

@@ -12619,7 +12619,7 @@ regions:
         link: 'http://www.meetup.com/Melbourne-Microservices-Meetup/'
         name: Melbourne Microservices Meetup
         description: |-
-          <p>This is a group interested in microservices, nodejs, react, flux, javascript where the members could help redifine a new architecure of javascript related solutions with microservices. Developers, business minded people, and solution architects all welcome. &nbsp;For anyone interested in learning more about me, I can be contacted at the following:</p>
+          <p>This is a group interested in microservices, nodejs, react, flux, javascript where the members could help redifine a new architecture of javascript related solutions with microservices. Developers, business minded people, and solution architects all welcome. &nbsp;For anyone interested in learning more about me, I can be contacted at the following:</p>
           <p><br></p>
           <p><a href="https://au.linkedin.com/in/matthewlowery">LinkedIn Profile</a></p>
           <p><a href="http://www.lowery.com/">My Blog</a></p>

typo architecure,

@bf4 bf4 force-pushed the correct_spelling branch from 853971d to c6393eb Compare February 9, 2017 16:49
As noted in nodejs#1128, there was non-English that was erroneously
modified in nodejs#1130
@bf4 bf4 force-pushed the correct_spelling branch from c6393eb to 9c5dacb Compare February 9, 2017 16:53
@bf4
Copy link
Contributor Author

bf4 commented Feb 9, 2017

@pin3da I reverted the entire changeset, then went more carefully through it and kept the corrections referenced in the pr description. So sorry about not noticing those changes.

@pin3da
Copy link
Contributor

pin3da commented Feb 9, 2017

@bf4 Thanks for your help (: !

I think that this correction is cool, but I see a problem, most of this data is taken from meetup.com and it will be overwritten after each update.

I think we sould merge this PR and then rebase #1128, are you agree ?

@bf4
Copy link
Contributor Author

bf4 commented Feb 10, 2017 via email

@pin3da pin3da merged commit 79f3a30 into nodejs:master Feb 11, 2017
@bf4 bf4 deleted the correct_spelling branch February 12, 2017 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants