Skip to content

Profiling Guide Requires Updates #447

Description

@Trott

In light of nodejs/node#3032, there is some stuff in the simple profiling guide that can be simplified. Maybe @matthewloring can indicate what needs to change? It might just be the part about making sure to use the same version of tick-processor as came with the source and how to fire up the tick processor? Not sure anything else...

Activity

  1. matthewloring commented on Jan 6, 2016

    @matthewloring
    Contributor

    @Trott Thank you for noticing this. I'll submit a PR with updates now that the tick processor is bundled with the node binary.

  2. srlowe commented on Mar 13, 2016

    @srlowe

    The page is still referring to the v8 profiling tools in the source code (which I believe are no longer included).

  3. matthewloring commented on Mar 14, 2016

    @matthewloring
    Contributor

    Good catch. Actually, the integration of the --prof-process flag into the LTS branch means we should remove all mention of scripts from the guide.

  4. added a commit that references this issue on Mar 14, 2016
    1e1aa2d
  5. ghost closed this as completedin #575on Mar 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions