-
-
Notifications
You must be signed in to change notification settings - Fork 115
Foundation launch changes #129
Conversation
This makes a number of interim changes for the foundation launch. 1. Addition of Linux Foundation header/footer boilerplate 2. Removal of "Sponsored by Joyent" branding 3. Addition of initial Foundation member logos 4. Update to trademark policy and visual guidelines 5. Update to About/Contribution section to point to new dev-policy 6. Temporary pointers to io.js site on download page 7. Contact link information
at request of Todd Benzies as these are not current
|
added 7f222c2 which removes the details about board members at request of Todd Benzies as these are not current |
|
@rvagg LGTM, some remarks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the link be to https://github.com/nodejs/node?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, fixed it.
|
Merged, still needs to be deployed, pinging @misterdjules. |
|
I have access to deploy and have also pushed your fix to the "converged" repo link |
|
Great, thanks. |
|
@fhemberger if you're around, could you help with changing the footer to say |
|
@rvagg @fhemberger @joyent/node-website Done with a532ff4. |
|
And deployed too. |
|
Cool, thanks @misterdjules! |
|
Most (if not all) existing banners on the site default to or have high pixel density versions. Most logos and images added in this commit also look pretty slick and HiDPI-friendly. However, the Linux Foundation banner added atop every page is not and looks a bit cheap in comparison now. Do we have a better rendering? |
|
@Krinkle funny you should ask, I just was trying to find a better source logo myself about 20 minutes ago. (I'm finally digging in deep in to the state of this repo for the first since the merger.) Let's open a new issue for this one. I'll open it with more details there and x-link. |

Closes #128
I've just pushed the attached commits live to nodejs.org as per instructions from @jasnell and @misterdjules. I've made some very minor tweaks & fixes in e23bae8 on top of @jasnell's original.
Can someone with access please merge this asap?