Skip to content
This repository was archived by the owner on Mar 25, 2018. It is now read-only.

Conversation

@rvagg
Copy link
Member

@rvagg rvagg commented Jun 16, 2015

Closes #128

I've just pushed the attached commits live to nodejs.org as per instructions from @jasnell and @misterdjules. I've made some very minor tweaks & fixes in e23bae8 on top of @jasnell's original.

Can someone with access please merge this asap?

jasnell and others added 3 commits June 16, 2015 20:30
This makes a number of interim changes for the foundation launch.

1. Addition of Linux Foundation header/footer boilerplate
2. Removal of "Sponsored by Joyent" branding
3. Addition of initial Foundation member logos
4. Update to trademark policy and visual guidelines
5. Update to About/Contribution section to point to new
   dev-policy
6. Temporary pointers to io.js site on download page
7. Contact link information
at request of Todd Benzies as these are not current
@rvagg
Copy link
Member Author

rvagg commented Jun 16, 2015

added 7f222c2 which removes the details about board members at request of Todd Benzies as these are not current

@fhemberger
Copy link
Contributor

@rvagg LGTM, some remarks:

  • Do you know if the mentioned email addresses (trademark/info/membership @ nodejs.org) are already operational?
  • Removed nonexistent background image "di_dark_gray.png" from foundation footer CSS (just some diagonal stripes).
  • Adjust footer max-width to match the rest of the site
  • Fixed typo "Poliicies"
  • contribute/index.md: Added issue link for the current nodejs.org website (this repo).
  • Fixed makefile, so the foundation member logos end up in the correct directory (before they ended up in /images/logos/logos)

@fhemberger fhemberger merged commit 7f222c2 into nodejs:master Jun 16, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the link be to https://github.com/nodejs/node?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, fixed it.

@fhemberger
Copy link
Contributor

Merged, still needs to be deployed, pinging @misterdjules.

@rvagg rvagg deleted the foundation-launch branch June 16, 2015 13:28
@rvagg
Copy link
Member Author

rvagg commented Jun 16, 2015

I have access to deploy and have also pushed your fix to the "converged" repo link

@fhemberger
Copy link
Contributor

Great, thanks.

@rvagg
Copy link
Member Author

rvagg commented Jun 16, 2015

@fhemberger if you're around, could you help with changing the footer to say © 2015 Node.js Foundation. instead of © 2015 Linux Foundation.. The LF folks picked that up and requested the change via email -- I just don't have a handle on the templating in this repo. Ping me in here when it's on master and I'll do a deploy if I'm still awake (heading to bed in a moment).

@misterdjules
Copy link

@rvagg @fhemberger @joyent/node-website Done with a532ff4.

@misterdjules
Copy link

And deployed too.

@fhemberger
Copy link
Contributor

Cool, thanks @misterdjules!

@Krinkle
Copy link

Krinkle commented Jun 20, 2015

Most (if not all) existing banners on the site default to or have high pixel density versions. Most logos and images added in this commit also look pretty slick and HiDPI-friendly. However, the Linux Foundation banner added atop every page is not and looks a bit cheap in comparison now. Do we have a better rendering?

screen shot

@snostorm
Copy link

@Krinkle funny you should ask, I just was trying to find a better source logo myself about 20 minutes ago. (I'm finally digging in deep in to the state of this repo for the first since the merger.)

Let's open a new issue for this one. I'll open it with more details there and x-link.

@snostorm
Copy link

Correction @Krinkle, an issue already exists at #133 -- Somebody also already referenced one of the images I tracked down ;) We can continue there.

@timaschew timaschew assigned timaschew and unassigned timaschew Jun 21, 2015
@nodejs nodejs locked and limited conversation to collaborators Jun 24, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updates for Foundation Announce

8 participants