Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

hotfix(language-detection): fix language detection #3021

Merged
merged 5 commits into from
Nov 17, 2022

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Nov 14, 2022

Description

This PR simply re-enables the browser language detection algorithm.

@ovflowd ovflowd added i18n All Issues regarding Localisation of the Website fast track labels Nov 14, 2022
@ovflowd
Copy link
Member Author

ovflowd commented Nov 14, 2022

cc @nodejs/nodejs-dev

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2022

Codecov Report

Base: 66.02% // Head: 68.20% // Increases project coverage by +2.18% 🎉

Coverage data is based on head (b76261e) compared to base (fd57b87).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3021      +/-   ##
==========================================
+ Coverage   66.02%   68.20%   +2.18%     
==========================================
  Files         118      144      +26     
  Lines        1351     1645     +294     
  Branches      342      388      +46     
==========================================
+ Hits          892     1122     +230     
- Misses        422      480      +58     
- Partials       37       43       +6     
Impacted Files Coverage Δ
src/templates/blog.tsx 0.00% <0.00%> (-100.00%) ⬇️
util-node/getNodeReleasesData.js 91.30% <0.00%> (-6.32%) ⬇️
src/__fixtures__/page.tsx 94.11% <0.00%> (-5.89%) ⬇️
src/pages/index.tsx 100.00% <0.00%> (ø)
src/templates/api.tsx 0.00% <0.00%> (ø)
src/templates/learn.tsx 100.00% <0.00%> (ø)
util-node/createSlug.js 100.00% <0.00%> (ø)
util-node/getNvmData.js 100.00% <0.00%> (ø)
src/hooks/useOnScreen.tsx 100.00% <0.00%> (ø)
src/pages/about/index.tsx 100.00% <0.00%> (ø)
... and 183 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ovflowd ovflowd merged commit 656a6e6 into nodejs:main Nov 17, 2022
@ovflowd ovflowd deleted the hotfix/use-browser-language-detection branch November 17, 2022 13:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
fast track i18n All Issues regarding Localisation of the Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants