Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

fix(layout): fixed a few mobile layout issues and api issues #2763

Merged
merged 15 commits into from
Sep 14, 2022

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Sep 13, 2022

Description

This PR fixes a few issues (mostly) for improving the usability of our website on mobile, such as:

  • Fix the Features section not aligning on mobile (Homepage)
  • Fix the Header to actually wrap the entries into multi-rows on mobile and nicely adjust its size
  • Fix Navigation to not depend on the variable of the header to calculate its position
  • Fix Navigation not being easily usable on mobile
  • Fix Community Paghes navigation not being able to scroll on mobile
  • Fix padding and margins for headings on mobile for articles
  • Fix API footer notes links not being correctly generated
  • Fix API navigation not being correctly generated due to missing navigationCreator.create() call
  • Fix API not sorting navigation entries correctly
  • Fix API version selector not pretending the locale URL
  • Fix API to remove empty whitespace lines

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build work fine.
  • I've covered new added functionality with unit tests if necessary.

@ovflowd ovflowd added bug Something isn't working enhancement New feature or request docs labels Sep 13, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2022

Codecov Report

Base: 66.02% // Head: 62.40% // Decreases project coverage by -3.61% ⚠️

Coverage data is based on head (a4a12d9) compared to base (fd57b87).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2763      +/-   ##
==========================================
- Coverage   66.02%   62.40%   -3.62%     
==========================================
  Files         118      124       +6     
  Lines        1351     1455     +104     
  Branches      342      361      +19     
==========================================
+ Hits          892      908      +16     
- Misses        422      506      +84     
- Partials       37       41       +4     
Impacted Files Coverage Δ
src/__fixtures__/page.tsx 94.11% <ø> (-5.89%) ⬇️
...components/ApiComponents/Components/ApiHeading.tsx 0.00% <ø> (ø)
...rc/components/ApiComponents/Components/ApiLink.tsx 0.00% <ø> (ø)
...ents/ApiComponents/Components/SourceLink/index.tsx 0.00% <ø> (ø)
...ApiComponents/Components/VersionSelector/index.tsx 0.00% <ø> (ø)
src/components/ApiComponents/index.tsx 0.00% <ø> (ø)
src/components/Article/index.tsx 100.00% <ø> (ø)
src/components/Banner/index.tsx 100.00% <ø> (ø)
src/components/Codebox/index.tsx 100.00% <ø> (ø)
src/components/EditLink/index.tsx 100.00% <ø> (ø)
... and 67 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@benhalverson benhalverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ovflowd ovflowd merged commit 3e0f417 into nodejs:main Sep 14, 2022
@ovflowd ovflowd deleted the fix/navigation-api-and-home branch September 14, 2022 08:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working docs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants