This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(layout): fixed a few mobile layout issues and api issues #2763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed ease transition
ovflowd
added
bug
Something isn't working
enhancement
New feature or request
docs
labels
Sep 13, 2022
ovflowd
requested review from
nschonni,
rodion-arr,
benhalverson and
manishprivet
September 13, 2022 18:19
Codecov ReportBase: 66.02% // Head: 62.40% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2763 +/- ##
==========================================
- Coverage 66.02% 62.40% -3.62%
==========================================
Files 118 124 +6
Lines 1351 1455 +104
Branches 342 361 +19
==========================================
+ Hits 892 908 +16
- Misses 422 506 +84
- Partials 37 41 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
benhalverson
approved these changes
Sep 14, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a few issues (mostly) for improving the usability of our website on mobile, such as:
navigationCreator.create()
callCheck List
npm run lint:js -- --fix
and/ornpm run lint:md -- --fix
for my JavaScript and/or Markdown changes.npm run test
to check if all tests are passing, and/ornpm run test -- -u
to update snapshots if I created and/or updated React Components.npm run build
work fine.