Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

chore: explicit dependency gatsbyjs/reach-router #2762

Merged
merged 1 commit into from
Sep 13, 2022
Merged

chore: explicit dependency gatsbyjs/reach-router #2762

merged 1 commit into from
Sep 13, 2022

Conversation

nschonni
Copy link
Member

Description

Running npm test locally, ESLint is giving an error for the import without an explicit dependency


Z:\nodejs.dev\src\components\Seo\index.tsx
  3:1  error  '@gatsbyjs/reach-router' should be listed in the project's dependencies. Run 'npm i -S @gatsbyjs/reach-router' to add it  import/no-extraneous-dependencies

Z:\nodejs.dev\src\hooks\useNavigateToDifferentLocale.ts
  2:1  error  '@gatsbyjs/reach-router' should be listed in the project's dependencies. Run 'npm i -S @gatsbyjs/reach-router' to add it  import/no-extraneous-dependencies

✖ 2 problems (2 errors, 0 warnings)

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build work fine.
  • I've covered new added functionality with unit tests if necessary.

@codecov-commenter
Copy link

Codecov Report

Merging #2762 (bdaf226) into main (fd57b87) will decrease coverage by 1.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2762      +/-   ##
==========================================
- Coverage   66.02%   64.65%   -1.38%     
==========================================
  Files         118      123       +5     
  Lines        1351     1406      +55     
  Branches      342      353      +11     
==========================================
+ Hits          892      909      +17     
- Misses        422      461      +39     
+ Partials       37       36       -1     
Impacted Files Coverage Δ
src/__fixtures__/page.tsx 94.11% <ø> (-5.89%) ⬇️
src/components/Article/index.tsx 100.00% <ø> (ø)
src/components/Codebox/index.tsx 100.00% <ø> (ø)
src/components/EditLink/index.tsx 100.00% <ø> (ø)
src/components/Header/index.tsx 100.00% <ø> (ø)
src/components/Layout/article.tsx 100.00% <ø> (ø)
src/components/NavigationItem/index.tsx 100.00% <ø> (ø)
src/components/SearchBar/index.tsx 52.30% <ø> (-1.03%) ⬇️
src/components/SideNavBar/index.tsx 88.88% <ø> (-3.42%) ⬇️
src/components/TableOfContents/index.tsx 59.37% <ø> (+5.52%) ⬆️
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@benhalverson benhalverson merged commit 61fa548 into nodejs:main Sep 13, 2022
@nschonni nschonni deleted the reach-router branch September 13, 2022 07:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants