You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 26, 2024. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR tackles the remaining MDX/Markdown issues from our repository. Basically, the current sync-api script still had some issues, and some of our Markdown pages are non-conforming, so this PR does the following:
Reorganises our ESLint configuration to be clean and modularised for each kind of file extension and to use mdx's plugins and parsers for parsing and lining markdown content
Updates Blog Posts and their Authors (syncing it from nodejs.org)
Also fixes the blog syncing script that was partially broken
Fix our content/** markdown pages by fixing Markdown and MDX issues on them
Generally fixing our Markdown files
Applying the new ESLint rules to the source code
Remove the outdated dependencies and non-used dependencies (decreasing our dependency graph by 20%)
Removed the Privacy page that should, from now on, redirect to the OpenJS Foundation page, as the privacy.md was gigantic and manually fixing Markdown issues there was not ideal. Also, nodejs.org now redirects users to OpenJS Foundation.
Note.: Review is better via the Commit tab as file changes are separated by commits. Most of the changes are automated changes by our API script or ESLint.
ovflowd
changed the title
fix(scripts): fixed blog generation script
refactor(mdx): fixed numerous mdx issues and improved mdx linting and parsing
Sep 12, 2022
ovflowd
changed the title
refactor(mdx): fixed numerous mdx issues and improved mdx linting and parsing
refactor(mdx): refactored linting rules and general markdown fixes
Sep 12, 2022
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR tackles the remaining MDX/Markdown issues from our repository. Basically, the current
sync-api
script still had some issues, and some of our Markdown pages are non-conforming, so this PR does the following:mdx
's plugins and parsers for parsing and lining markdown contentcontent/**
markdown pages by fixing Markdown and MDX issues on themRelated Issues
Check List
npm run lint:js -- --fix
and/ornpm run lint:md -- --fix
for my JavaScript and/or Markdown changes.npm run test
to check if all tests are passing, and/ornpm run test -- -u
to update snapshots if I created and/or updated React Components.npm run build
work fine.