Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

feat(workflows): updated github actions workflows #2750

Merged
merged 6 commits into from
Sep 12, 2022

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Sep 12, 2022

Description

This PR updates the workflows by giving common names, grouping correlated jobs, and fixing the GitHub Pages workflow to add a PATH-PREFIX, it also ensures all are using Node.js v16.

Related Issues

Relates to https://github.com/nodejs/nodejs.dev/issues/2749

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build work fine.
  • I've covered new added functionality with unit tests if necessary.

@ovflowd ovflowd added the Infrastructure Infra related task label Sep 12, 2022
@ovflowd
Copy link
Member Author

ovflowd commented Sep 12, 2022

cc @nschonni @MylesBorins

@benhalverson benhalverson added the create-preview Generate preview on staging.nodejs.dev label Sep 12, 2022
@github-actions github-actions bot removed the create-preview Generate preview on staging.nodejs.dev label Sep 12, 2022
@benhalverson
Copy link
Member

why are you deleting the test.yml workflow?

@ovflowd
Copy link
Member Author

ovflowd commented Sep 12, 2022

why are you deleting the test.yml workflow?

It became just one workflow with two jobs. We don't need so many workflow files 🙈

@github-actions
Copy link

Please find a preview at: https://staging.nodejs.dev/2750/

@ovflowd ovflowd merged commit 20843c6 into nodejs:main Sep 12, 2022
@ovflowd ovflowd deleted the chore/updated-workflows branch September 12, 2022 10:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Infrastructure Infra related task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants