Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

fix(content): numerous content and design issues #2727

Merged
merged 3 commits into from
Sep 8, 2022

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Sep 7, 2022

Description

This PR does a few design and content fixes such as:

  • Positioning of the "arrown" SVG from the Community Navigation bar
  • Fixes the Home page showing wrong version as LTS and confusing message
  • Fixes wrong width adjustment for the API Docs page

Related Issues

Closes https://github.com/nodejs/nodejs.dev/issues/2723
Closes https://github.com/nodejs/nodejs.dev/issues/2714

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build work fine.
  • I've covered new added functionality with unit tests if necessary.

@ovflowd ovflowd added bug Something isn't working enhancement New feature or request labels Sep 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2727 (626f6d9) into main (d56388c) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #2727   +/-   ##
=======================================
  Coverage   68.83%   68.83%           
=======================================
  Files         119      119           
  Lines        1325     1325           
  Branches      332      333    +1     
=======================================
  Hits          912      912           
  Misses        379      379           
  Partials       34       34           
Impacted Files Coverage Δ
src/components/Hero/index.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ovflowd ovflowd added the create-preview Generate preview on staging.nodejs.dev label Sep 7, 2022
@github-actions github-actions bot removed the create-preview Generate preview on staging.nodejs.dev label Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

Please find a preview at: https://staging.nodejs.dev/2727/

@ovflowd
Copy link
Member Author

ovflowd commented Sep 7, 2022

@manishprivet could I get a quick approval here as this is a hot-fix?

@benhalverson
Copy link
Member

This doesn't look any less confusing compared to the current version. The suggestion in #2714 was to put the version number in the LTS button.

@ovflowd
Copy link
Member Author

ovflowd commented Sep 8, 2022

@benhalverson I've just updated the design to match the suggestion.

@ovflowd ovflowd added the create-preview Generate preview on staging.nodejs.dev label Sep 8, 2022
@github-actions github-actions bot removed the create-preview Generate preview on staging.nodejs.dev label Sep 8, 2022
@github-actions
Copy link

github-actions bot commented Sep 8, 2022

Please find a preview at: https://staging.nodejs.dev/2727/

Copy link
Member

@benhalverson benhalverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@ovflowd ovflowd merged commit ee88ffb into nodejs:main Sep 8, 2022
@ovflowd ovflowd deleted the fixes/design-content branch September 8, 2022 08:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Responsive issue on Layouts Homepage download button has a confusing label
3 participants