This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1k
fix(content): numerous content and design issues #2727
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2727 +/- ##
=======================================
Coverage 68.83% 68.83%
=======================================
Files 119 119
Lines 1325 1325
Branches 332 333 +1
=======================================
Hits 912 912
Misses 379 379
Partials 34 34
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
github-actions
bot
removed
the
create-preview
Generate preview on staging.nodejs.dev
label
Sep 7, 2022
Please find a preview at: https://staging.nodejs.dev/2727/ |
@manishprivet could I get a quick approval here as this is a hot-fix? |
This doesn't look any less confusing compared to the current version. The suggestion in #2714 was to put the version number in the LTS button. |
@benhalverson I've just updated the design to match the suggestion. |
github-actions
bot
removed
the
create-preview
Generate preview on staging.nodejs.dev
label
Sep 8, 2022
Please find a preview at: https://staging.nodejs.dev/2727/ |
benhalverson
approved these changes
Sep 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR does a few design and content fixes such as:
Related Issues
Closes https://github.com/nodejs/nodejs.dev/issues/2723
Closes https://github.com/nodejs/nodejs.dev/issues/2714
Check List
npm run lint:js -- --fix
and/ornpm run lint:md -- --fix
for my JavaScript and/or Markdown changes.npm run test
to check if all tests are passing, and/ornpm run test -- -u
to update snapshots if I created and/or updated React Components.npm run build
work fine.