Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

firebase(caching): do not cache the service worker in any hypothesis #2648

Merged
merged 2 commits into from
Aug 18, 2022

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Aug 17, 2022

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run lint:js -- --fix and/or npm run lint:md -- --fix for my JavaScript and/or Markdown changes.
    • This is important as most of the cases your code changes might not be correctly linted
  • I have run npm run test to check if all tests are passing, and/or npm run test -- -u to update snapshots if I created and/or updated React Components.
  • I have checked that the build works locally and that npm run build work fine.
  • I've covered new added functionality with unit tests if necessary.

Description

This PR introduces support to Workbox v6, and fixes Firebase hosting caching the sw.js when it should not. By using the latest version of Workbox it introduces several improvements for caching, performance and routing.

Related Issues

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2022

Codecov Report

Merging #2648 (08658c4) into main (f49d318) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #2648   +/-   ##
=======================================
  Coverage   83.46%   83.46%           
=======================================
  Files         103      103           
  Lines        1113     1113           
  Branches      310      310           
=======================================
  Hits          929      929           
  Misses        178      178           
  Partials        6        6           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ovflowd
Copy link
Member Author

ovflowd commented Aug 18, 2022

Just a reminder that this solution is temporary until (gatsbyjs/gatsby#31542) gets merged. I subscribed to the PR just in case.

@ovflowd ovflowd merged commit 57456b7 into nodejs:main Aug 18, 2022
@ovflowd ovflowd deleted the refactor/workbox branch August 18, 2022 07:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants