Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

fix: Storybook build #2147

Merged
merged 1 commit into from
Dec 30, 2021
Merged

fix: Storybook build #2147

merged 1 commit into from
Dec 30, 2021

Conversation

nschonni
Copy link
Member

  • Added missing @babel plugins causing initial build issue
  • Downgrade node-sass since it is incompatible with current CRA
  • Removed unreferenced storybook plug-in that is subdependency already
  • Add Storybook build to CI to prevent future regressions

- Added missing @babel plugins causing initial build issue
- Downgrade node-sass since it is incompatible with current CRA
- Removed unreferenced storybook plug-in that is subdependency already
- Add Storybook build to CI to prevent future regressions
@codecov-commenter
Copy link

Codecov Report

Merging #2147 (fff69b4) into main (e3677be) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2147   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files          81       81           
  Lines         891      891           
  Branches      246      246           
=======================================
  Hits          811      811           
  Misses         79       79           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3677be...fff69b4. Read the comment docs.

@nschonni nschonni requested a review from MylesBorins December 30, 2021 20:30
@MylesBorins MylesBorins merged commit 0a217ec into nodejs:main Dec 30, 2021
@nschonni nschonni deleted the fix-storybook branch December 30, 2021 22:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants