Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor test-async-wrap-* #9663

Closed
wants to merge 1 commit into from
Closed

test: refactor test-async-wrap-* #9663

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 17, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test async_wrap

Description of change
  • assert.equal() -> assert.strictEqual()
  • add duration to setTimeout()

@Trott
test: refactor test-async-wrap-*
3c55126 
* `assert.equal()` -> `assert.strictEqual()`
* add duration to `setTimeout()`
@Trott Trott added async_wrap test Issues and PRs related to the tests. labels Nov 17, 2016
@Trott
Copy link
Member Author

Trott commented Nov 18, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/4903/

Trott added a commit to Trott/io.js that referenced this pull request Nov 21, 2016
@Trott
test: refactor test-async-wrap-*
d6dc2e8 
* `assert.equal()` -> `assert.strictEqual()`
* add duration to `setTimeout()`

PR-URL: nodejs#9663
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
@Trott
Copy link
Member Author

Trott commented Nov 21, 2016

Landed in d6dc2e8

@Trott Trott closed this Nov 21, 2016
addaleax pushed a commit that referenced this pull request Nov 22, 2016
@Trott @addaleax
test: refactor test-async-wrap-*
a220170 
* `assert.equal()` -> `assert.strictEqual()`
* add duration to `setTimeout()`

PR-URL: #9663
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@Trott @addaleax
test: refactor test-async-wrap-*
9e4ce6f 
* `assert.equal()` -> `assert.strictEqual()`
* add duration to `setTimeout()`

PR-URL: nodejs#9663
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@Trott @MylesBorins
test: refactor test-async-wrap-*
b59cf58 
* `assert.equal()` -> `assert.strictEqual()`
* add duration to `setTimeout()`

PR-URL: #9663
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@Trott @MylesBorins
test: refactor test-async-wrap-*
21d7051 
* `assert.equal()` -> `assert.strictEqual()`
* add duration to `setTimeout()`

PR-URL: #9663
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@Trott @MylesBorins
test: refactor test-async-wrap-*
02719f0 
* `assert.equal()` -> `assert.strictEqual()`
* add duration to `setTimeout()`

PR-URL: #9663
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
@Trott Trott deleted the async-wrap-test-refactor branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@princejwesley princejwesley princejwesley approved these changes

@lpinca lpinca lpinca approved these changes

@santigimeno santigimeno santigimeno approved these changes

@jasnell jasnell jasnell approved these changes

@bnoordhuis bnoordhuis bnoordhuis approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @bnoordhuis @jasnell @santigimeno @lpinca @princejwesley @cjihrig @MylesBorins @addaleax