deps: update V8 to 5.5

[targos]

Checklist

• make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

V8

Description of change

This PR updates V8 to the current 5.5-lkgr branch.

/cc @nodejs/v8

Previous discussion: nodejs/v8#2

CI: https://ci.nodejs.org/job/node-test-pull-request/4849/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/417/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/422/

[Fishrock123]

As brought up in nodejs/v8#2 I'm quite skeptical this is a good idea until we get better hooks for native promises. (Which seemed to be the plan to get in before node version 8, where this was originally supposed to land.)

[mhdawson]

CI run to validate across platforms: https://ci.nodejs.org/job/node-test-commit-v8-linux/421/

[bnoordhuis]

As brought up in nodejs/v8#2 I'm quite skeptical this is a good idea until we get better hooks for native promises.

That's a pretty cryptic comment on its own. I think the missing context is that 5.5 ships async/await without a flag?

[mhdawson]

Looks like CI failures across the board.

[jbergstroem]

Afaik smartos14 support is dropped for 5.5

[targos]

Updated.

There are some new utf-8 fixes (1, 2) that make test/parallel/test-string-decoder fail. I'm sure that someone already mentioned it but I can't find the related issue.

Example failure:

test('utf-8', Buffer.from('F0B841', 'hex'), '\ufffd\ufffdA');
// AssertionError: Expected "\ufffd\ufffd\u41", but got "\ufffd\u41"

If I change the expected value, the error is inverted:

test('utf-8', Buffer.from('F0B841', 'hex'), '\ufffdA');
// AssertionError: Expected "\ufffd\u41", but got "\ufffd\ufffd\u41"

[ofrobots]

@targos see discussion here: v8@af842a7#commitcomment-19855022

[targos]

I'm turning the PR into a clean semver-major that can land on master. I'll then open another one to backport to v7.x.

[targos]

This is still in progress because of v8@af842a7#commitcomment-19855022

[targos]

@nodejs/platform-smartos What are we going to do with SmartOS 14? The CI cannot be green because of the incompatibility with this platform.

[jbergstroem]

@targos as far as I know, it is to be dropped for 55 and forward. I can look at skipping testing against smartos14 for a specific node version; for instance 7.3?

[misterdjules]

@targos FWIW, what @jbergstroem mentioned:

as far as I know, it is to be dropped for 55 and forward.

sounds good to me.

P.S: sorry for the delay, I was on vacation until today.

[mhdawson]

CI run one more time: https://ci.nodejs.org/job/node-test-pull-request/6073/

[targos]

Landed in a67a04d...24ef1e6. Thanks everyone!

[pi0]

@targos Congratulations and thanks for hard work :) So does it lands on 7.x semver-minor updates? And what is your ETA?
Thanks again :)
Update: It seems back-port is on progress here #11029 :))

[iddan]

Is this means we can use async/await safely?

[kyrylkov]

@aniddan In nightly builds, yes. In Node 7.x not yet, be V8 5.5 wasn't backported yet (#11029)

[leodutra]

Will it be included in version 8 without flags?
Very well done @targos.

[kyrylkov]

@leodutra It is already in master branch, thus in Node.js 8

[joaocgreis]

@targos https://github.com/nodejs/node/blob/master/BUILDING.md#unix still mentions Clang 3.4 as the required version. Do you know what the new required version is?

[targos]

@joaocgreis I don't know what is the actual required version but since we dropped the workaround from #8343 it must be at least 3.4.2.