tools: enable ES2016 support in ESLint #9218
Conversation
|
@thefourtheye you're right. Though I would be surprised if V8 didn't just convert this operator to a |
|
@targos Looks like, in |
|
Linter CI run: https://ci.nodejs.org/job/node-test-linter/4942/ |
|
@thefourtheye LGTY ? |
|
@targos What about the other features in es2016? Do we have any rough idea if they will also be performing at par with their es2015 equivalents? Because once we allow them in the linter it means that we officially allow es2016 in our codebase. |
|
The exponentiation operator is the only new syntax of ES2016. This change doesn't add support for other features. |
| @@ -1,6 +1,8 @@ | |||
| env: | |||
| node: true | |||
| es6: true | |||
| parserOptions: | |||
There was a problem hiding this comment.
Nit: what about adding a blank line before this one?
|
Maybe I can change the commit message to |
This allows us to use the exponentiation operator. PR-URL: nodejs#9218 Ref: nodejs#9208 (comment) Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
|
Landed in 6031d8e |
This allows us to use the exponentiation operator. PR-URL: #9218 Ref: #9208 (comment) Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This allows us to use the exponentiation operator. PR-URL: #9218 Ref: #9208 (comment) Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This allows us to use the exponentiation operator. PR-URL: #9218 Ref: #9208 (comment) Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tools
Description of change
This allows to use the exponentiation operator.
Ref: #9208 (comment)