Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: speed up module loading #9132

Merged
merged 2 commits into from
Oct 24, 2016
Merged

src: speed up module loading #9132

merged 2 commits into from
Oct 24, 2016

Commits on Oct 24, 2016

  1. src: speed up module loading, skip EOF read 

    Stop reading from disk when we read fewer bytes than requested because
the next read will be the zero-sized EOF.

PR-URL: nodejs#9132
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    35e8896 View commit details
    Browse the repository at this point in the history

  2. src: speed up module loading, don't resize buffer 

    Don't bother shrinking the read buffer on the final read because we
dispose it immediately afterwards.  Avoids some unnecessary memory
allocation and copying.

PR-URL: nodejs#9132
Reviewed-By: James M Snell <jasnell@gmail.com>
    @bnoordhuis
    bnoordhuis committed Oct 24, 2016
    Configuration menu
    Copy the full SHA
    d52f5dc View commit details
    Browse the repository at this point in the history