Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup test file write stream #8894

Closed
wants to merge 5 commits into from
Closed

Cleanup test file write stream #8894

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
04f673b
test: file-write-stream, replace var with const/let
sudaraka Oct 2, 2016
522047a
test: file-write-stream, add strict assert/comparison
sudaraka Oct 2, 2016
ca9099e
test: file-write-stream, remove unnecessary very IIFE
sudaraka Oct 2, 2016
42cb021
test: file-write-stream, use template literals
sudaraka Oct 2, 2016
592a9bc
test: file-write-stream, add strict assert/comparison (2)
sudaraka Oct 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 16 additions & 18 deletions test/parallel/test-file-write-stream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,18 @@
'use strict';
var common = require('../common');
var assert = require('assert');
const common = require('../common');
const assert = require('assert');

var path = require('path');
var fs = require('fs');
var fn = path.join(common.tmpDir, 'write.txt');
const path = require('path');
const fs = require('fs');
const fn = path.join(common.tmpDir, 'write.txt');
common.refreshTmpDir();
var file = fs.createWriteStream(fn, {
const file = fs.createWriteStream(fn, {
highWaterMark: 10
});

var EXPECTED = '012345678910';
const EXPECTED = '012345678910';

var callbacks = {
const callbacks = {
open: -1,
drain: -2,
close: -1
Expand All @@ -22,19 +22,19 @@ file
.on('open', function(fd) {
console.error('open!');
callbacks.open++;
assert.equal('number', typeof fd);
assert.strictEqual('number', typeof fd);
})
.on('error', function(err) {
throw err;
})
.on('drain', function() {
console.error('drain!', callbacks.drain);
callbacks.drain++;
if (callbacks.drain == -1) {
assert.equal(EXPECTED, fs.readFileSync(fn, 'utf8'));
if (callbacks.drain === -1) {
assert.strictEqual(EXPECTED, fs.readFileSync(fn, 'utf8'));
file.write(EXPECTED);
} else if (callbacks.drain == 0) {
assert.equal(EXPECTED + EXPECTED, fs.readFileSync(fn, 'utf8'));
} else if (callbacks.drain === 0) {
assert.strictEqual(EXPECTED + EXPECTED, fs.readFileSync(fn, 'utf8'));
file.end();
}
})
Expand All @@ -51,14 +51,12 @@ file
fs.unlinkSync(fn);
});

for (var i = 0; i < 11; i++) {
(function(i) {
file.write('' + i);
})(i);
for (let i = 0; i < 11; i++) {
file.write('' + i);
}

process.on('exit', function() {
for (var k in callbacks) {
for (const k in callbacks) {
assert.equal(0, callbacks[k], k + ' count off by ' + callbacks[k]);
Copy link
Member

@lpinca lpinca Oct 2, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: how about using strictEqual and a template literal here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing it out. Updated it.

}
console.log('ok');
Expand Down