Skip to content

test: removes FIXME parallel/test-repl-persistent-history #8756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ALJCepeda wants to merge 1 commit into from
Closed

test: removes FIXME parallel/test-repl-persistent-history #8756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 3 additions & 13 deletions test/parallel/test-repl-persistent-history.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,17 +139,7 @@ const tests = [
test: [UP, CLEAR, '\'42\'', ENTER],
expected: [prompt, convertMsg, prompt, prompt + '\'=^.^=\'', prompt, '\'',
'4', '2', '\'', '\'42\'\n', prompt, prompt],
after: function ensureHistoryFixture() {
// XXX(Fishrock123) Make sure nothing weird happened to our fixture
// or it's temporary copy.
// Sometimes this test used to erase the fixture and I'm not sure why.
const history = fs.readFileSync(historyFixturePath, 'utf8');
assert.strictEqual(history,
'\'you look fabulous today\'\n\'Stay Fresh~\'\n');
const historyCopy = fs.readFileSync(historyPath, 'utf8');
assert.strictEqual(historyCopy, '\'you look fabulous today\'' + os.EOL +
'\'Stay Fresh~\'' + os.EOL);
}
clean: false
},
{ // Requires the above testcase
env: {},
Expand Down Expand Up @@ -229,7 +219,7 @@ function runTest(assertCleaned) {
const env = opts.env;
const test = opts.test;
const expected = opts.expected;
const after = opts.after;
const clean = opts.clean;
const before = opts.before;

if (before) before();
Expand Down Expand Up @@ -275,7 +265,7 @@ function runTest(assertCleaned) {
});

function onClose() {
const cleaned = after ? after() : cleanupTmpFile();
const cleaned = clean === false ? false : cleanupTmpFile();

try {
// Ensure everything that we expected was output
Expand Down