Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo: join => joins [ci skip] #8522

Closed
wants to merge 1 commit into from
Closed

typo: join => joins [ci skip] #8522

wants to merge 1 commit into from

Conversation

kalmanh
Copy link
Contributor

@kalmanh kalmanh commented Sep 13, 2016 •
edited by Fishrock123
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem. labels Sep 13, 2016
@Fishrock123
Copy link
Contributor

Fishrock123 commented Sep 13, 2016 •
edited
Loading

LGTM, but could you please change typo: to doc: in the commit itself?

(Bonus points: no [ci skip], and add what file it touches in the commit message.)

@cjihrig
Copy link
Contributor

cjihrig commented Sep 13, 2016

LGTM

@kalmanh kalmanh closed this Sep 14, 2016
@kalmanh kalmanh mentioned this pull request Sep 14, 2016
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kalmanh @Fishrock123 @cjihrig @nodejs-github-bot