vm: change ContextifyScript to Script in comment #8415
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reading the comment at the top of the vm.js, I think that ContextifyScript should perhaps just be Script.
|
LGTM |
| @@ -4,7 +4,7 @@ const binding = process.binding('contextify'); | |||
| const Script = binding.ContextifyScript; | |||
|
|
|||
| // The binding provides a few useful primitives: | |||
| // - ContextifyScript(code, { filename = "evalmachine.anonymous", | |||
| // - Script(code, { filename = "evalmachine.anonymous", | |||
| // displayErrors = true } = {}) | |||
There was a problem hiding this comment.
Nit: I think this line was aligned with the previous line's filename.
There was a problem hiding this comment.
Yep, need to reduce the indentation
There was a problem hiding this comment.
Ah thanks, I'll fix that.
|
LGTM |
3 similar comments
|
LGTM |
|
LGTM |
|
LGTM |
danbev
changed the title
fhinkel
pushed a commit
that referenced
this pull request
Sep 8, 2016
Reading the comment at the top of the vm.js, I think that ContextifyScript should perhaps just be Script. PR-URL: #8415 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franzih@chromium.org> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in da0651a |
|
@fhinkel Thanks for merging this! |
|
Sure. Thanks for contributing! |
Fishrock123
pushed a commit
that referenced
this pull request
Sep 14, 2016
Reading the comment at the top of the vm.js, I think that ContextifyScript should perhaps just be Script. PR-URL: #8415 Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franzih@chromium.org> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
should this be backported to v4? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
vm
Description of change
Reading the comment at the top of the vm.js, I think that
ContextifyScriptshould perhaps just beScript.