doc: update authors list again #8346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
doc
| @@ -898,10 +900,11 @@ zoubin <zoubin04@gmail.com> | |||
| Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com> | |||
| Saquib <saquibofficial@gmail.com> | |||
| Daniel Sellers <daniel@designfrontier.net> | |||
| Julien Waechter <julien.waechter@gmail.com> | |||
| julien.waechter <julien.waechter@gmail.com> | |||
There was a problem hiding this comment.
nope... the update-authors tool changed a bunch of these. I'm changing them back
|
@jasnell Rumkin is ok. |
jasnell
force-pushed
the
update-authors-2
branch
from
54a7352
to
5afca95
Compare
|
Ok, @nodejs/collaborators ... I think this is ready to go. PTAL |
| @@ -890,6 +892,7 @@ Nik Nyby <nnyby@columbia.edu> | |||
| Ben Ripkens <bripkens.dev@gmail.com> | |||
| Ryan Sobol <contact@ryansobol.com> | |||
| jona <jona@jona.io> | |||
| Anna Henningsen <sqrt@entless.org> | |||
There was a problem hiding this comment.
yay, I’m duplicate! 😄 (this one is the one which should be removed)
There was a problem hiding this comment.
ha! I thought I caught all of those. thanks! :-)
|
LGTM! :) |
|
@jasnell why not edit |
|
heh... that would make far too much sense ;-) ... good idea! |
2 tasks
|
@ChALkeR ... does this LGTY? |
|
LGTM |
1 similar comment
|
LGTM |
| surya panikkal <surya.com@gmail.com> | ||
| vsemozhetbyt <vsemozhetbyt@gmail.com> | ||
| Surya Panikkal <surya.com@gmail.com> | ||
| Vse Mozhet Byt <vsemozhetbyt@gmail.com> |
There was a problem hiding this comment.
This line should be probably kept as it was, ref: #6373 (comment)
It's that time again! Another round of author list updates.
jasnell
force-pushed
the
update-authors-2
branch
from
0cf1248
to
05251de
Compare
|
@ChALkeR ... updated! |
|
Thanks for the edit, looks good. |
|
LGTM |
jasnell
added a commit
that referenced
this pull request
Sep 4, 2016
It's that time again! Another round of author list updates. PR-URL: #8346 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
|
Landed in dfe1c7e. Thanks all! |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
It's that time again! Another round of author list updates. PR-URL: nodejs#8346 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 9, 2016
It's that time again! Another round of author list updates. PR-URL: #8346 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
It's that time again! Another round of author list updates. PR-URL: #8346 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
It's that time again! Another round of author list updates. PR-URL: #8346 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
It's that time again! Another round of author list updates. PR-URL: #8346 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
It's that time again! Another round of author list updates. PR-URL: #8346 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Another round of
AUTHORS.mdupdates. This is an initial take. The list needs to be cleaned with duplicates removed and real names added. Help is appreciated! :-) /cc @nodejs/collaboratorsNote: All of the edits on this were generated automatically by the update-authors tool. It's quite likely that there are incorrect edits.