Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add test for attempted multiple IPC channels #8159

Merged
merged 1 commit into from
Aug 20, 2016

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 18, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

This error was previously not covered. This commit adds coverage.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 18, 2016
@cjihrig cjihrig added the child_process Issues and PRs related to the child_process subsystem. label Aug 18, 2016
@Trott
Copy link
Member

Trott commented Aug 18, 2016

LGTM if CI is green

@santigimeno
Copy link
Member

This error was previously not covered. This commit adds coverage.

PR-URL: nodejs#8159
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@cjihrig cjihrig merged commit ae4ce9f into nodejs:master Aug 20, 2016
@cjihrig cjihrig deleted the test branch August 20, 2016 20:17
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
This error was previously not covered. This commit adds coverage.

PR-URL: #8159
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
This error was previously not covered. This commit adds coverage.

PR-URL: #8159
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
This error was previously not covered. This commit adds coverage.

PR-URL: #8159
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
This error was previously not covered. This commit adds coverage.

PR-URL: #8159
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
This error was previously not covered. This commit adds coverage.

PR-URL: #8159
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
This error was previously not covered. This commit adds coverage.

PR-URL: #8159
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants