doc: fix typo #8107
Closed
doc: fix typo #8107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
|
LGTM |
|
LGTM. |
|
LGTM |
querystring subsystem docs referred to `obj.hashOwnProperty()` which is non-existent. Corrected to `obj.hasOwnProperty()`.
|
@princejwesley I've amended the commit message per your recommendation. |
|
LGTM |
|
I think this definitely qualifies for the "trivial change" exception to the "wait 48 hours" rule so I'm going to ahead and land it right now... |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Aug 15, 2016
querystring subsystem docs referred to `obj.hashOwnProperty()` which is non-existent. Corrected to `obj.hasOwnProperty()`. PR-URL: nodejs#8107 Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
|
Landed in 24e4488. Thanks for the fix! |
evanlucas
pushed a commit
that referenced
this pull request
Aug 20, 2016
querystring subsystem docs referred to `obj.hashOwnProperty()` which is non-existent. Corrected to `obj.hasOwnProperty()`. PR-URL: #8107 Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
None, just a tiny doc change
Description of change
Fix a typo in the
querystringdocs:obj.hashOwnProperty()→obj.hasOwnProperty().