benchmark: Repair the fs/readfile benchmark #7818
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sorin Baltateanu <sorin.baltateanu@intel.com>
nodejs-github-bot
added
the
benchmark
Member
|
I'm unable to recreate the exception on macos and I'm not sure if introducing a timer here is the best approach. Pinging @mscdex for his thoughts... |
Member
|
I remember having seen that error too, but it should be fixed after 8bb59fd landed. Though this fix may be better. |
rvagg
force-pushed
the
master
branch
2 times, most recently
from
c133999 to
83c7a88
Compare
addaleax
approved these changes
Feb 22, 2017
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
This stil seems to make sense to me.
jasnell
approved these changes
Mar 24, 2017
jasnell
pushed a commit
that referenced
this pull request
Mar 24, 2017
PR-URL: #7818 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
|
Landed in d9b0e4c |
Contributor
|
I'm confused as to why this was merged when there was already a |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 28, 2017
PR-URL: #7818 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
The readfile benchmark of fs type was throwing an exception because the benchmark tried to read the file after it got unlinked at the end of the run.
Signed-off-by: Sorin Baltateanu sorin.baltateanu@intel.com