Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: v8_inspector no longer depends on wtf #7751

Closed
wants to merge 1 commit into from
Closed

deps: v8_inspector no longer depends on wtf #7751

wants to merge 1 commit into from

Conversation

ofrobots
Copy link
Contributor

@ofrobots ofrobots commented Jul 15, 2016 •
edited
Loading

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps:v8_inspector

Description of change

Remove wtf files as v8_inspector no longer needs them.

Ref: #7123

@ofrobots
deps: v8_inspector no longer depends on wtf
62514fd 
Remove wtf files as v8_inspector no longer needs them.

Ref: nodejs#7123
@nodejs-github-bot nodejs-github-bot added the inspector Issues and PRs related to the V8 inspector protocol label Jul 15, 2016
@ofrobots ofrobots mentioned this pull request Jul 15, 2016
Closed
@cjihrig
Copy link
Contributor

cjihrig commented Jul 15, 2016

LGTM

@ofrobots
Copy link
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/3303/

@targos
Copy link
Member

targos commented Jul 15, 2016

LGTM

1 similar comment
@JungMinu
Copy link
Member

LGTM

@gibfahn gibfahn mentioned this pull request Jul 18, 2016
Merged
@targos
Copy link
Member

targos commented Jul 19, 2016

landed in 257a866

@targos targos closed this Jul 19, 2016
targos pushed a commit that referenced this pull request Jul 19, 2016
@ofrobots @targos
deps: v8_inspector no longer depends on wtf
257a866 
Remove wtf files as v8_inspector no longer needs them.

Ref: #7123

PR-URL: #7751
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
evanlucas pushed a commit that referenced this pull request Jul 19, 2016
@ofrobots @evanlucas
deps: v8_inspector no longer depends on wtf
f3182f6 
Remove wtf files as v8_inspector no longer needs them.

Ref: #7123

PR-URL: #7751
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
evanlucas pushed a commit that referenced this pull request Jul 20, 2016
@ofrobots @evanlucas
deps: v8_inspector no longer depends on wtf
cf8a488 
Remove wtf files as v8_inspector no longer needs them.

Ref: #7123

PR-URL: #7751
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ofrobots @cjihrig @targos @JungMinu @MylesBorins @nodejs-github-bot