Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: clean up string_search #7174

Merged
merged 1 commit into from
Jun 14, 2016
Merged

src: clean up string_search #7174

merged 1 commit into from
Jun 14, 2016

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Jun 6, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)
  • src (string_search)
Description of change

This commit removes some unnecessary signed checks on unsigned variables and removes a few unused private functions.

@mscdex mscdex added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Jun 6, 2016
@mscdex
Copy link
Contributor Author

mscdex commented Jun 6, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2933/

@thefourtheye
Copy link
Contributor

LGTM if CI is green.

@bnoordhuis
Copy link
Member

LGTM

3 similar comments
@addaleax
Copy link
Member

addaleax commented Jun 6, 2016

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Jun 6, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Jun 6, 2016

LGTM

@mscdex
src: clean up string_search
f914f37 
This commit removes some unnecessary signed checks on unsigned
variables and removes a few unused private functions.

PR-URL: nodejs#7174
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@mscdex mscdex merged commit f914f37 into nodejs:master Jun 14, 2016
@mscdex mscdex deleted the src-lint branch June 14, 2016 20:13
evanlucas pushed a commit that referenced this pull request Jun 16, 2016
@mscdex @evanlucas
src: clean up string_search
cf0928c 
This commit removes some unnecessary signed checks on unsigned
variables and removes a few unused private functions.

PR-URL: #7174
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Jun 16, 2016
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
@MylesBorins
Copy link
Contributor

@mscdex lts?

@mscdex
Copy link
Contributor Author

mscdex commented Jul 11, 2016 •
edited
Loading

@thealphanerd Yeah I believe it should be safe enough.

@MylesBorins
Copy link
Contributor

@mscdex it unfortunately doesn't land cleanly. Would you be willing to backport?

@mscdex mscdex mentioned this pull request Jul 12, 2016
Closed
mscdex added a commit to mscdex/io.js that referenced this pull request Jul 12, 2016
@mscdex
src: clean up string_search
13abb8d 
This commit removes some unnecessary signed checks on unsigned
variables.

PR-URL: nodejs#7174
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@mscdex
src: clean up string_search
6519e02 
This commit removes some unnecessary signed checks on unsigned
variables.

PR-URL: #7174
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@mscdex
src: clean up string_search
2b79221 
This commit removes some unnecessary signed checks on unsigned
variables.

PR-URL: #7174
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@mscdex
src: clean up string_search
d863327 
This commit removes some unnecessary signed checks on unsigned
variables.

PR-URL: #7174
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 14, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mscdex @thefourtheye @bnoordhuis @addaleax @cjihrig @jasnell @MylesBorins