Fix 6899: console.* not working when running out of stack space #6907

addaleax · 2016-05-20T21:47:57Z

Checklist

tests and code linting passes
a test and/or benchmark is included
the commit message follows commit guidelines

Affected core subsystem(s)

vm, module(?), console(?)

Description of change

Commit 1: vm: don't abort process when stack space runs out

Make less assumptions about what objects will be available when vm context creation or error message printing fail because V8 runs out of JS stack space.

Commit 2: module: don't cache uninitialized builtins

Don't cache the exported values of fully uninitialized builtins. This works by adding an additional loading flag that is only active during initial loading of an internal module and checking that either the module is fully loaded or is in that state before using its cached value.

This has the effect that builtins modules which could not be loaded (e.g. because compilation failed due to missing stack space) can be loaded at a later point.

I’m definitely open for the possibility of leaving the module commit out, if others think this specific bug is not worth fixing beyond not aborting the process.

Initial CI: https://ci.nodejs.org/job/node-test-commit/3417/

bnoordhuis · 2016-05-21T08:42:11Z

src/node_contextify.cc

@@ -58,6 +58,9 @@ class ContextifyContext {
 public:
  ContextifyContext(Environment* env, Local<Object> sandbox_obj) : env_(env) {
    Local<Context> v8_context = CreateV8Context(env, sandbox_obj);
+    if (v8_context.IsEmpty())


The context_.IsEmpty() check below already takes care of this. persistent_handle.Reset(isolate, empty_handle) is functionally equivalent to persistent_handle.Reset().

@bnoordhuis I won’t be able to take care of that until at least tomorrow… could you double-check that? I was actually getting a fatal error due to this, and I was surprised that the check below didn’t catch that and this one did.

Works for me locally.

EDIT: Just so we're talking about the same thing:

diff --git a/src/node_contextify.cc b/src/node_contextify.cc index ae88223..2b23c08 100644 --- a/src/node_contextify.cc +++ b/src/node_contextify.cc @@ -58,9 +58,6 @@ class ContextifyContext { public: ContextifyContext(Environment* env, Local<Object> sandbox_obj) : env_(env) { Local<Context> v8_context = CreateV8Context(env, sandbox_obj); - if (v8_context.IsEmpty()) - return; - context_.Reset(env->isolate(), v8_context); // Allocation failure or maximum call stack size reached

@bnoordhuis Sorry, you’re right, I must have had something else in mind…

bnoordhuis · 2016-05-21T08:56:00Z

LGTM, by the way.

addaleax · 2016-05-21T23:06:11Z

Updated based on @bnoordhuis’ suggestions.

New CI: https://ci.nodejs.org/job/node-test-commit/3428/

bnoordhuis · 2016-05-22T06:43:22Z

src/node_contextify.cc

@@ -58,6 +58,7 @@ class ContextifyContext {
 public:
  ContextifyContext(Environment* env, Local<Object> sandbox_obj) : env_(env) {
    Local<Context> v8_context = CreateV8Context(env, sandbox_obj);
+


Whitespace change.

bnoordhuis · 2016-05-22T06:47:18Z

LGTM with style nits. The CI failures are probably all flakes but you may want to rerun it, just in case.

Make less assumptions about what objects will be available when vm context creation or error message printing fail because V8 runs out of JS stack space. Ref: nodejs#6899

Don't cache the exported values of fully uninitialized builtins. This works by adding an additional `loading` flag that is only active during initial loading of an internal module and checking that either the module is fully loaded or is in that state before using its cached value. This has the effect that builtins modules which could not be loaded (e.g. because compilation failed due to missing stack space) can be loaded at a later point. Fixes: nodejs#6899

addaleax · 2016-05-22T11:37:42Z

Addressed nits… CI rerun (although I think some of the failures were infrastructure-related): https://ci.nodejs.org/job/node-test-commit/3435/

addaleax · 2016-05-24T15:05:38Z

Landed in 4bd410b, dab0987

Make less assumptions about what objects will be available when vm context creation or error message printing fail because V8 runs out of JS stack space. Ref: #6899 PR-URL: #6907 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Don't cache the exported values of fully uninitialized builtins. This works by adding an additional `loading` flag that is only active during initial loading of an internal module and checking that either the module is fully loaded or is in that state before using its cached value. This has the effect that builtins modules which could not be loaded (e.g. because compilation failed due to missing stack space) can be loaded at a later point. Fixes: #6899 PR-URL: #6907 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Make less assumptions about what objects will be available when vm context creation or error message printing fail because V8 runs out of JS stack space. Ref: nodejs#6899 PR-URL: nodejs#6907 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Don't cache the exported values of fully uninitialized builtins. This works by adding an additional `loading` flag that is only active during initial loading of an internal module and checking that either the module is fully loaded or is in that state before using its cached value. This has the effect that builtins modules which could not be loaded (e.g. because compilation failed due to missing stack space) can be loaded at a later point. Fixes: nodejs#6899 PR-URL: nodejs#6907 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Make less assumptions about what objects will be available when vm context creation or error message printing fail because V8 runs out of JS stack space. Ref: #6899 PR-URL: #6907 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Don't cache the exported values of fully uninitialized builtins. This works by adding an additional `loading` flag that is only active during initial loading of an internal module and checking that either the module is fully loaded or is in that state before using its cached value. This has the effect that builtins modules which could not be loaded (e.g. because compilation failed due to missing stack space) can be loaded at a later point. Fixes: #6899 PR-URL: #6907 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins · 2016-06-03T01:40:26Z

@addaleax lts?

addaleax · 2016-06-03T01:46:32Z

@thealphanerd Backport is linked above (#6957) :)

MylesBorins · 2016-06-03T01:49:47Z

OH YEAH... I was waiting for it to live in a release... this is what I get for doing things on autopilot

Make less assumptions about what objects will be available when vm context creation or error message printing fail because V8 runs out of JS stack space. Ref: #6899 PR-URL: #6907 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Don't cache the exported values of fully uninitialized builtins. This works by adding an additional `loading` flag that is only active during initial loading of an internal module and checking that either the module is fully loaded or is in that state before using its cached value. This has the effect that builtins modules which could not be loaded (e.g. because compilation failed due to missing stack space) can be loaded at a later point. Fixes: #6899 Ref: #6899 PR-URL: #6907 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Make less assumptions about what objects will be available when vm context creation or error message printing fail because V8 runs out of JS stack space. Ref: #6899 PR-URL: #6907 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Don't cache the exported values of fully uninitialized builtins. This works by adding an additional `loading` flag that is only active during initial loading of an internal module and checking that either the module is fully loaded or is in that state before using its cached value. This has the effect that builtins modules which could not be loaded (e.g. because compilation failed due to missing stack space) can be loaded at a later point. Fixes: #6899 Ref: #6899 PR-URL: #6907 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

addaleax added module Issues and PRs related to the module subsystem. vm Issues and PRs related to the vm subsystem. console Issues and PRs related to the console subsystem. labels May 20, 2016

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels May 20, 2016

addaleax mentioned this pull request May 20, 2016

FATAL ERROR: v8::FromJust Maybe value is Nothing #6899

Closed

bnoordhuis reviewed May 21, 2016
View reviewed changes

addaleax force-pushed the fix-6899 branch 2 times, most recently from acac585 to 715342d Compare May 21, 2016 23:04

bnoordhuis reviewed May 22, 2016
View reviewed changes

addaleax added 2 commits May 22, 2016 13:12

vm: don't abort process when stack space runs out

5116d98

Make less assumptions about what objects will be available when vm context creation or error message printing fail because V8 runs out of JS stack space. Ref: nodejs#6899

addaleax force-pushed the fix-6899 branch from 715342d to 7ad588e Compare May 22, 2016 11:12

addaleax closed this May 24, 2016

addaleax deleted the fix-6899 branch May 24, 2016 15:05

addaleax mentioned this pull request May 24, 2016

Backport 6907 to v4.x (console.* not working when running out of stack space) #6957

Closed

3 tasks

MylesBorins mentioned this pull request Jun 2, 2016

Audit commits not found on v4.x-staging #7116

Closed

MylesBorins added the lts-watch-v4.x label Jun 3, 2016

addaleax removed the lts-watch-v4.x label Jun 3, 2016

MylesBorins added the dont-land-on-v4.x label Jun 3, 2016

MylesBorins mentioned this pull request Jul 12, 2016

v4.5.0 proposal #7688

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix 6899: console.* not working when running out of stack space #6907

Fix 6899: console.* not working when running out of stack space #6907

addaleax commented May 20, 2016 •

edited

Loading

bnoordhuis May 21, 2016

addaleax May 21, 2016

bnoordhuis May 21, 2016 •

edited

Loading

addaleax May 21, 2016

bnoordhuis commented May 21, 2016

addaleax commented May 21, 2016

bnoordhuis May 22, 2016

bnoordhuis commented May 22, 2016

addaleax commented May 22, 2016

addaleax commented May 24, 2016

MylesBorins commented Jun 3, 2016

addaleax commented Jun 3, 2016

MylesBorins commented Jun 3, 2016

Fix 6899: console.* not working when running out of stack space #6907

Fix 6899: console.* not working when running out of stack space #6907

Conversation

addaleax commented May 20, 2016 • edited Loading

Checklist

Affected core subsystem(s)

Description of change

bnoordhuis May 21, 2016

Choose a reason for hiding this comment

addaleax May 21, 2016

Choose a reason for hiding this comment

bnoordhuis May 21, 2016 • edited Loading

Choose a reason for hiding this comment

addaleax May 21, 2016

Choose a reason for hiding this comment

bnoordhuis commented May 21, 2016

addaleax commented May 21, 2016

bnoordhuis May 22, 2016

Choose a reason for hiding this comment

bnoordhuis commented May 22, 2016

addaleax commented May 22, 2016

addaleax commented May 24, 2016

MylesBorins commented Jun 3, 2016

addaleax commented Jun 3, 2016

MylesBorins commented Jun 3, 2016

addaleax commented May 20, 2016 •

edited

Loading

bnoordhuis May 21, 2016 •

edited

Loading