Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix mkdtemp example by removing hyphen #6834

Closed
wants to merge 1 commit into from
Closed

doc: fix mkdtemp example by removing hyphen #6834

wants to merge 1 commit into from

Conversation

thefourtheye
Copy link
Contributor

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

The example uses only /tmp, not /tmp-. So, the result cannot be
/tmp-abc123, but just /tmpabc123.

cc @jasnell

@thefourtheye
doc: fix mkdtemp example by removing hyphen
0d44be3 
The example uses only `/tmp`, not `/tmp-`. So, the result cannot be
`/tmp-abc123`, but just `/tmpabc123`.
@thefourtheye thefourtheye added the doc Issues and PRs related to the documentations. label May 18, 2016
thefourtheye referenced this pull request May 18, 2016
@jasnell
doc: clarify fs.mkdtemp prefix argument
2ccba1f 
Per: #6142

Clarify the prefix argument.

Fixes: #6142
PR-URL: #6800
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
@addaleax addaleax added the fs Issues and PRs related to the fs subsystem / file system. label May 18, 2016
@addaleax
Copy link
Member

LGTM

@jasnell
Copy link
Member

jasnell commented May 18, 2016

LGTM! Thank you!
On May 18, 2016 3:12 AM, "Sakthipriyan Vairamani" notifications@github.com
wrote:

Checklist

  • documentation is changed or added
  • the commit message follows commit guidelines

Affected core subsystem(s)

doc
Description of change

The example uses only /tmp, not /tmp-. So, the result cannot be
/tmp-abc123, but just /tmpabc123.

cc @jasnell https://github.com/jasnell

You can view, comment on, or merge this pull request online at:

#6834
Commit Summary

  • doc: fix mkdtemp example by removing hyphen

File Changes

Patch Links:

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#6834

@cjihrig
Copy link
Contributor

cjihrig commented May 18, 2016

LGTM

jasnell pushed a commit that referenced this pull request May 20, 2016
@thefourtheye @jasnell
doc: fix mkdtemp example by removing hyphen
acc1142 
The example uses only `/tmp`, not `/tmp-`. So, the result cannot be
`/tmp-abc123`, but just `/tmpabc123`.

PR-URL: #6834
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented May 20, 2016

Landed in acc1142

@jasnell jasnell closed this May 20, 2016
@thefourtheye thefourtheye deleted the fix-mkdtemp-example branch May 20, 2016 14:55
Fishrock123 pushed a commit that referenced this pull request May 23, 2016
@thefourtheye @Fishrock123
doc: fix mkdtemp example by removing hyphen
adebbc3 
The example uses only `/tmp`, not `/tmp-`. So, the result cannot be
`/tmp-abc123`, but just `/tmpabc123`.

PR-URL: #6834
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Jun 2, 2016
@thefourtheye @rvagg
doc: fix mkdtemp example by removing hyphen
8a0329f 
The example uses only `/tmp`, not `/tmp-`. So, the result cannot be
`/tmp-abc123`, but just `/tmpabc123`.

PR-URL: #6834
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 2, 2016
Closed
@thefourtheye thefourtheye mentioned this pull request Jul 12, 2016
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thefourtheye @addaleax @jasnell @cjihrig @MylesBorins