Skip to content

Conversation

@Trott
Copy link
Member

@Trott Trott commented May 14, 2016

Checklist
  • tests and code linting passes
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

@Trott Trott added the doc Issues and PRs related to the documentations. label May 14, 2016
@mscdex mscdex added the child_process Issues and PRs related to the child_process subsystem. label May 14, 2016
@r-52
Copy link
Contributor

r-52 commented May 14, 2016

LGTM

2 similar comments
@jasnell
Copy link
Member

jasnell commented May 15, 2016

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented May 15, 2016

LGTM

jasnell pushed a commit that referenced this pull request May 17, 2016
PR-URL: #6760
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell
Copy link
Member

jasnell commented May 17, 2016

Landed in b55becd

@jasnell jasnell closed this May 17, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
PR-URL: #6760
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott Trott deleted the cpmax branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants