Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update "who to cc in issues" chart #6694

Merged
merged 1 commit into from
Jun 24, 2016
Merged

doc: update "who to cc in issues" chart #6694

merged 1 commit into from
Jun 24, 2016

Conversation

Fishrock123
Copy link
Contributor

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

See #6655

@nodejs/collaborators please let us know if you think you should be listed here or not.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 11, 2016
@Fishrock123 Fishrock123 mentioned this pull request May 11, 2016
Closed
addaleax
addaleax reviewed May 11, 2016
View reviewed changes
doc/onboarding-extras.md
| `lib/child_process` | @cjihrig, @bnoordhuis |
| `lib/cluster` | @cjihrig, @bnoordhuis |
| `lib/assert` | @Trott |
| `lib/buffer` | @trevnorris, @nodejs/buffer |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trevnorris ∈ @nodejs/buffer :)

mscdex
mscdex reviewed May 11, 2016
View reviewed changes
doc/onboarding-extras.md
| `lib/{_}http{*}` | @indutny, @bnoordhuis, @mscdex, @nodejs/http |
| `lib/net` | @indutny, @bnoordhuis, @nodejs/streams |
| `lib/fs`, `src/{fs|file}` | @bnoordhuis, @jasnell, @saghul, @trevnorris |
| `lib/{_}http{*}` | @bnoordhuis, @indutny, @mscdex, @nodejs/http |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/@mscdex//

I am already in in nodejs/http

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As is @indutny ... I can add @bnoordhuis to it right now also

jasnell
jasnell reviewed May 11, 2016
View reviewed changes
doc/onboarding-extras.md
| `lib/{crypto,tls,https}` | @nodejs/crypto |
| `lib/domains` | @misterdjules |
| `lib/{_}http{*}` | @indutny, @bnoordhuis, @mscdex, @nodejs/http |
| `lib/net` | @indutny, @bnoordhuis, @nodejs/streams |
| `lib/fs`, `src/{fs|file}` | @bnoordhuis, @jasnell, @saghul, @trevnorris |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created the nodejs/fs team with these initial members

jasnell
jasnell reviewed May 11, 2016
View reviewed changes
doc/onboarding-extras.md
| upgrading npm | @thealphanerd, @fishrock123 |
| upgrading v8 | @nodejs/v8, @nodejs/post-mortem |
| upgrading npm | @fishrock123, @thealphanerd |
| upgrading c-ares | @jbergstroem, @nodejs/http |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong line for nodejs/http

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(we store it as deps/cares)

Hopefully we can use this as part of the bot at some stage?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been thinking we could re-use the bot's logic for resolving PR labels, for /cc-ing as well. Who to /cc for which label could be read from this file.

@orangemocha
Copy link
Contributor

We could add @nodejs/platform-windows for tools/msvs/* (mostly for the MSI).

@Trott
Copy link
Member

Trott commented May 12, 2016

LGTM once the c-ares/http error on line 25 is fixed and nodejs/http is added to line 26 (http-parser).

IMO, other nits/comments can be addressed now or in subsequent PRs. Fine by me either way.

@ronkorving
Copy link
Contributor

Feel free to add me to the fs group.

@addaleax addaleax added the meta Issues and PRs related to the general management of the project. label May 17, 2016
@eljefedelrodeodeljefe
Copy link
Contributor

@Fishrock123 ping

@MylesBorins
Copy link
Contributor

@Fishrock123 want me to take this over?

@Fishrock123
Copy link
Contributor Author

Updated, LGTEveryone?

@MylesBorins
Copy link
Contributor

LGTM

2 similar comments
@Trott
Copy link
Member

Trott commented Jun 17, 2016

LGTM

@addaleax
Copy link
Member

LGTM

@Trott
Copy link
Member

Trott commented Jun 22, 2016

@RReverser Looks like this PR already updates the who-to-cc for buffer to the correct group.

@RReverser
Copy link
Member

@Trott. Great! LGTM.

@Fishrock123
doc: update "who to cc in issues" chart
f5cddad 
Refs: nodejs#6655

PR-URL: nodejs#6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
@Fishrock123 Fishrock123 merged commit f5cddad into nodejs:master Jun 24, 2016
@phillipj phillipj mentioned this pull request Jun 24, 2016
Closed
Fishrock123 added a commit that referenced this pull request Jun 27, 2016
@Fishrock123
doc: update "who to cc in issues" chart
b5e9010 
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
@Fishrock123 Fishrock123 mentioned this pull request Jun 27, 2016
Merged
Fishrock123 added a commit that referenced this pull request Jul 5, 2016
@Fishrock123
doc: update "who to cc in issues" chart
09a7c91 
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
@Fishrock123
doc: update "who to cc in issues" chart
4d33838 
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Fishrock123 @MylesBorins
doc: update "who to cc in issues" chart
748702a 
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Fishrock123
doc: update "who to cc in issues" chart
be8b3b3 
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Fishrock123
doc: update "who to cc in issues" chart
7394aa5 
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Fishrock123
doc: update "who to cc in issues" chart
f0d7193 
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Fishrock123
doc: update "who to cc in issues" chart
9122b3b 
Refs: #6655

PR-URL: #6694
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.