stream: skip idle webstreams start and watchers by mcollina · Pull Request #66424 · nodejs/node

mcollina · 2026-09-30T21:09:18Z

Round 21 of the webstreams performance work (follows #66392). It targets what a stream costs before its first chunk and after its last one: construction, tee() and pipeTo() setup and shutdown.

No post-start microtask for sources without `pull()`

setupReadableStreamDefaultController queued a microtask after every start() to flip the controller's started flag and call pull() if needed. That flag only gates calls into the pull algorithm, so for a source without pull() (push-style sources that enqueue from start(), or new ReadableStream()) the step has nothing observable left to do. The flag is now set synchronously in that case and no closure or task is allocated. Sources with pull() keep the microtask, at the same position. Byte streams get the same treatment.

This also stops a burst of short-lived streams from being kept alive until the next microtask checkpoint, which is where most of the time in the creation benchmark went.

Closed watchers as records instead of promises

pipeTo() holds the only references to its reader and writer, and tee() to its reader, so their [[closedPromise]] records are never observed as promises. Each pipe still materialized both records plus a reaction to watch for close and error, and each tee one record plus a reaction. The watchers are now installed as the records themselves (ClosedPromiseHook), the way the pipe's ready hook already worked: the settle sites resolve or reject the record where they would have settled the promise, and the hook enqueues the watcher at the microtask position its reaction would have had. The erroring and release paths probe the record's promise, so every hook carries one shared forever-pending promise, which setPromiseHandled() skips.

The tee's cancel promise is materialized by the first branch cancel only.

Tests

test/parallel/test-whatwg-readablestream-tee-cancel-settle.js covers the cancel promise settling before and after materialization (cancel one branch then close or error the source, close then cancel both, cancel both) and a tee of an already errored source, for default and byte streams.

A 53-scenario microtask-ordering stress (pull, push, iterators, tee incl. byte tee, pipeTo incl. every shutdown path, transform backpressure, ReadableStream.from, writers) logs identically against main, also with --no-async-context-frame. WPT streams and the webstreams parallel batch are green.

Benchmark

node benchmark/compare.js --runs 20 over benchmark/webstreams:

                                                                       confidence improvement accuracy (*)    (**)   (***)
webstreams/adapters.js kind='readable-from-web' n=100000                              -1.36 %       ±3.06%  ±4.09%  ±5.38%
webstreams/adapters.js kind='readable-to-web' n=100000                                -0.64 %       ±3.22%  ±4.32%  ±5.69%
webstreams/adapters.js kind='writable-from-web' n=100000                              -1.29 %       ±5.43%  ±7.29%  ±9.60%
webstreams/adapters.js kind='writable-to-web' n=100000                                -1.19 %       ±4.96%  ±6.70%  ±8.92%
webstreams/creation.js kind='ReadableStream.tee' n=50000                      ***     20.47 %       ±3.27%  ±4.39%  ±5.79%
webstreams/creation.js kind='ReadableStream' n=50000                          ***    172.40 %      ±14.62% ±19.68% ±26.07%
webstreams/creation.js kind='ReadableStreamBYOBReader' n=50000                ***     15.66 %       ±7.78% ±10.44% ±13.76%
webstreams/creation.js kind='ReadableStreamDefaultReader' n=50000             ***     14.53 %       ±5.73%  ±7.73% ±10.26%
webstreams/creation.js kind='TransformStream' n=50000                                  0.03 %       ±3.21%  ±4.30%  ±5.65%
webstreams/creation.js kind='WritableStream' n=50000                                   4.36 %       ±5.38%  ±7.24%  ±9.60%
webstreams/encoding-streams.js len=1024 kind='decode' n=100000                         3.12 %       ±3.96%  ±5.30%  ±6.97%
webstreams/encoding-streams.js len=1024 kind='encode' n=100000                         0.22 %       ±1.55%  ±2.07%  ±2.73%
webstreams/encoding-streams.js len=16 kind='decode' n=100000                          -1.41 %       ±3.78%  ±5.09%  ±6.75%
webstreams/encoding-streams.js len=16 kind='encode' n=100000                           1.70 %       ±2.27%  ±3.04%  ±4.00%
webstreams/from.js kind='async' n=1000000                                             -0.07 %       ±2.17%  ±2.90%  ±3.82%
webstreams/from.js kind='sync' n=1000000                                              -2.50 %       ±2.77%  ±3.72%  ±4.89%
webstreams/js_transfer.js n=10000 payload='ReadableStream'                            -0.80 %       ±2.08%  ±2.80%  ±3.72%
webstreams/js_transfer.js n=10000 payload='TransformStream'                            0.84 %       ±1.03%  ±1.38%  ±1.82%
webstreams/js_transfer.js n=10000 payload='WritableStream'                      *      1.74 %       ±1.44%  ±1.92%  ±2.53%
webstreams/lifecycle.js kind='async-iterator' n=50000                                  2.02 %       ±5.05%  ±6.76%  ±8.90%
webstreams/lifecycle.js kind='pipe-through' n=50000                                   -1.06 %       ±3.49%  ±4.68%  ±6.17%
webstreams/lifecycle.js kind='pipe-to' n=50000                                         8.60 %      ±10.55% ±14.13% ±18.58%
webstreams/lifecycle.js kind='readable' n=50000                                       -1.55 %       ±3.15%  ±4.22%  ±5.55%
webstreams/pipe-through.js kind='default' n=500000                                     2.93 %       ±3.31%  ±4.44%  ±5.87%
webstreams/pipe-through.js kind='transform' n=500000                                  -1.88 %       ±2.63%  ±3.54%  ±4.70%
webstreams/pipe-to.js highWaterMarkW=1 highWaterMarkR=1 n=500000                       0.58 %       ±3.34%  ±4.48%  ±5.90%
webstreams/pipe-to.js highWaterMarkW=1 highWaterMarkR=1024 n=500000                    1.08 %       ±2.26%  ±3.03%  ±3.99%
webstreams/pipe-to.js highWaterMarkW=1 highWaterMarkR=4096 n=500000                   -1.24 %       ±1.64%  ±2.20%  ±2.90%
webstreams/pipe-to.js highWaterMarkW=1024 highWaterMarkR=1 n=500000                   -0.66 %       ±2.30%  ±3.09%  ±4.08%
webstreams/pipe-to.js highWaterMarkW=1024 highWaterMarkR=1024 n=500000                 0.60 %       ±2.39%  ±3.21%  ±4.23%
webstreams/pipe-to.js highWaterMarkW=1024 highWaterMarkR=4096 n=500000                -0.31 %       ±2.10%  ±2.81%  ±3.70%
webstreams/pipe-to.js highWaterMarkW=4096 highWaterMarkR=1 n=500000                   -0.67 %       ±2.09%  ±2.80%  ±3.68%
webstreams/pipe-to.js highWaterMarkW=4096 highWaterMarkR=1024 n=500000                -0.77 %       ±2.80%  ±3.76%  ±4.96%
webstreams/pipe-to.js highWaterMarkW=4096 highWaterMarkR=4096 n=500000                -1.60 %       ±2.47%  ±3.31%  ±4.37%
webstreams/readable-async-iterator.js type='bytes' n=100000                            1.17 %       ±2.53%  ±3.39%  ±4.46%
webstreams/readable-async-iterator.js type='normal' n=100000                           1.62 %       ±5.17%  ±6.94%  ±9.16%
webstreams/readable-read-buffered.js bufferSize=1 n=100000                             0.09 %       ±5.16%  ±6.92%  ±9.13%
webstreams/readable-read-buffered.js bufferSize=10 n=100000                            2.98 %       ±4.40%  ±5.90%  ±7.79%
webstreams/readable-read-buffered.js bufferSize=100 n=100000                          -1.04 %       ±4.42%  ±5.93%  ±7.80%
webstreams/readable-read-buffered.js bufferSize=1000 n=100000                          6.55 %       ±7.43%  ±9.97% ±13.15%
webstreams/readable-read.js type='byob' n=100000                                       0.18 %       ±1.34%  ±1.79%  ±2.35%
webstreams/readable-read.js type='normal' n=100000                                    -1.02 %       ±4.63%  ±6.21%  ±8.17%
webstreams/tee.js type='bytes' n=100000                                               -0.89 %       ±2.04%  ±2.73%  ±3.61%
webstreams/tee.js type='normal' n=100000                                               0.20 %       ±2.22%  ±2.97%  ±3.91%
webstreams/writable-write.js type='await' n=100000                                     2.10 %       ±2.82%  ±3.80%  ±5.03%
webstreams/writable-write.js type='queued' n=100000                                    1.90 %       ±2.45%  ±3.31%  ±4.41%

The lifecycle.js rows re-run with 40 samples, since the pipe-to row has a wide interval:

                                                      confidence improvement accuracy (*)   (**)   (***)
webstreams/lifecycle.js kind='async-iterator' n=50000                 0.77 %       ±3.42% ±4.54%  ±5.88%
webstreams/lifecycle.js kind='pipe-through' n=50000                   1.56 %       ±2.91% ±3.86%  ±5.00%
webstreams/lifecycle.js kind='pipe-to' n=50000                **     10.98 %       ±7.03% ±9.33% ±12.09%
webstreams/lifecycle.js kind='readable' n=50000                      -0.67 %       ±2.13% ±2.83%  ±3.67%

The long-running rows (pipe-to, pipe-through, tee, read, from) are flat as expected: the savings are per stream, per pipe and per tee, not per chunk. A local harness that creates and drains a 4-chunk push-style stream measured +22 %, and a 4-chunk pipe +10 %.

AI generated, humanly reviewed.

nodejs-github-bot · 2026-09-30T21:09:23Z

Review requested:

@nodejs/performance

codecov · 2026-10-02T09:48:13Z

Codecov Report

❌ Patch coverage is 98.30508% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.41%. Comparing base (9a85290) to head (9605461).
⚠️ Report is 99 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/internal/webstreams/readablestream.js	98.19%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #66424    +/-   ##
========================================
  Coverage   90.40%   90.41%            
========================================
  Files         791      791            
  Lines      276120   276496   +376     
  Branches    53032    53099    +67     
========================================
+ Hits       249634   249995   +361     
- Misses      16896    16902     +6     
- Partials     9590     9599     +9

Files with missing lines	Coverage Δ
lib/internal/webstreams/util.js	`97.13% <100.00%> (+0.06%)`	⬆️
lib/internal/webstreams/readablestream.js	`98.10% <98.19%> (+0.02%)`	⬆️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gurgunday

lgtm

nodejs-github-bot · 2026-10-03T14:48:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/78154/

github-actions · 2026-10-04T07:20:37Z

Failed to resume CI

✖  Cannot resume PR CI job 78154: Jenkins does not offer a "Resume build" action. Check the existing CI run in Jenkins and rebase the PR if needed. To start a new CI run manually: ncu-ci run https://github.com/nodejs/node/pull/66424
   ✖  https://ci.nodejs.org/job/node-test-pull-request/78154/

Full Auto Start CI output

�[36m⠋�[39m Validating Jenkins credentials
�[36m⠋�[39m Validating Jenkins credentials
✔  Jenkins credentials valid
�[36m⠙�[39m Looking for CI runs for pull request 66424
�[36m⠙�[39m Looking for CI runs for pull request 66424
�[36m⠙�[39m Getting PR from nodejs/node/pull/66424
�[36m⠙�[39m Getting reviews from nodejs/node/pull/66424
�[36m⠙�[39m Getting comments from nodejs/node/pull/66424
✔  Found PR CI job 78154
�[36m⠹�[39m Querying data for job/node-test-pull-request/78154/
�[36m⠹�[39m Querying data for job/node-test-pull-request/78154/
�[36m⠹�[39m Querying API for job/node-test-pull-request/78154/
✔  Build data downloaded
�[36m⠹�[39m Checking whether PR CI job 78154 can be resumed
�[36m⠹�[39m Checking whether PR CI job 78154 can be resumed
✖  Cannot resume PR CI job 78154: Jenkins does not offer a "Resume build" action. Check the existing CI run in Jenkins and rebase the PR if needed. To start a new CI run manually: ncu-ci run https://github.com/nodejs/node/pull/66424
   ✖  https://ci.nodejs.org/job/node-test-pull-request/78154/

View workflow run

github-actions · 2026-10-06T03:31:20Z

This pull request has conflicts with its base branch, removing the author ready label.
Please rebase your branch onto the latest base branch, resolve the conflicts locally, and force-push.
Afterwards the pull request needs a fresh collaborator approval, and a collaborator will add the label back once it is author ready again.

A source without pull() has nothing observable left to do in its post-start step, since the started flag only gates calls into the pull algorithm. Set the flag right away instead of from a microtask, so a push-style ReadableStream allocates neither the closure nor the task and is not kept alive until the next microtask checkpoint. pipeTo and tee hold the only references to their reader and writer, so their [[closedPromise]] records are never observed as promises. Install the watchers as the records themselves, as pipeTo's ready hook already does, instead of materializing a promise plus reaction per side, and hand the erroring/release probes one shared pending promise. The tee's cancel promise is likewise materialized by the first branch cancel. Microtask ordering is unchanged: each hook enqueues its watcher at the position the promise reaction would have had. node benchmark/compare.js --runs 20 over benchmark/webstreams (46 rows, all others within the confidence interval): webstreams/creation.js kind='ReadableStream' *** +172.40% webstreams/creation.js kind='ReadableStream.tee' *** +20.47% webstreams/creation.js kind='ReadableStreamBYOBReader' *** +15.66% webstreams/creation.js kind='ReadableStreamDefaultReader' *** +14.53% webstreams/lifecycle.js kind='pipe-to' (40 runs) ** +10.98% Signed-off-by: Matteo Collina <hello@matteocollina.com>

nodejs-github-bot · 2026-10-07T04:51:25Z

CI: https://ci.nodejs.org/job/node-test-pull-request/78234/

github-actions · 2026-10-07T08:13:45Z

Benchmark GHA (webstreams): https://github.com/nodejs/node/actions/runs/37592351706

Results

[!WARNING]
Do not take GHA benchmark results as face value, always confirm them
using a dedicated machine, e.g. Jenkins CI.

Benchmark results:

                                                                       confidence improvement accuracy (*)    (**)   (***)
webstreams/adapters.js kind='readable-from-web' n=100000                              -0.58 %       ±6.87%  ±9.06% ±11.62%
webstreams/adapters.js kind='readable-to-web' n=100000                                 2.35 %      ±11.71% ±15.44% ±19.81%
webstreams/adapters.js kind='writable-from-web' n=100000                               0.38 %       ±6.15%  ±8.11% ±10.41%
webstreams/adapters.js kind='writable-to-web' n=100000                                 1.72 %       ±7.14%  ±9.41% ±12.08%
webstreams/creation.js kind='ReadableStream.tee' n=50000                      ***     21.79 %       ±6.64%  ±8.76% ±11.24%
webstreams/creation.js kind='ReadableStream' n=50000                          ***    185.00 %      ±12.67% ±16.73% ±21.54%
webstreams/creation.js kind='ReadableStreamBYOBReader' n=50000                ***     11.33 %       ±5.71%  ±7.52%  ±9.66%
webstreams/creation.js kind='ReadableStreamDefaultReader' n=50000             ***     16.37 %       ±6.48%  ±8.55% ±10.97%
webstreams/creation.js kind='TransformStream' n=50000                                  4.05 %       ±6.10%  ±8.04% ±10.32%
webstreams/creation.js kind='WritableStream' n=50000                                  -0.05 %       ±5.08%  ±6.69%  ±8.59%
webstreams/encoding-streams.js len=1024 kind='decode' n=100000                         0.38 %       ±6.15%  ±8.10% ±10.40%
webstreams/encoding-streams.js len=1024 kind='encode' n=100000                        -2.04 %       ±9.89% ±13.03% ±16.72%
webstreams/encoding-streams.js len=16 kind='decode' n=100000                          -0.40 %       ±6.96%  ±9.18% ±11.77%
webstreams/encoding-streams.js len=16 kind='encode' n=100000                          -0.29 %       ±7.16%  ±9.44% ±12.11%
webstreams/from.js kind='async' n=1000000                                              0.34 %       ±4.36%  ±5.75%  ±7.38%
webstreams/from.js kind='sync' n=1000000                                               0.61 %       ±4.70%  ±6.20%  ±7.95%
webstreams/js_transfer.js n=10000 payload='ReadableStream'                            -1.28 %       ±9.35% ±12.33% ±15.82%
webstreams/js_transfer.js n=10000 payload='TransformStream'                           -0.18 %       ±8.69% ±11.46% ±14.71%
webstreams/js_transfer.js n=10000 payload='WritableStream'                             2.37 %       ±9.20% ±12.13% ±15.56%
webstreams/lifecycle.js kind='async-iterator' n=50000                                  1.26 %       ±5.00%  ±6.60%  ±8.46%
webstreams/lifecycle.js kind='pipe-through' n=50000                                    3.38 %       ±4.89%  ±6.45%  ±8.27%
webstreams/lifecycle.js kind='pipe-to' n=50000                                         4.02 %       ±6.22%  ±8.20% ±10.52%
webstreams/lifecycle.js kind='readable' n=50000                                        0.42 %       ±3.93%  ±5.18%  ±6.65%
webstreams/pipe-through.js kind='default' n=500000                                     0.25 %       ±5.50%  ±7.25%  ±9.30%
webstreams/pipe-through.js kind='transform' n=500000                                   0.33 %       ±5.30%  ±6.99%  ±8.97%
webstreams/pipe-to.js highWaterMarkW=1 highWaterMarkR=1 n=500000                       0.99 %       ±5.76%  ±7.60%  ±9.75%
webstreams/pipe-to.js highWaterMarkW=1 highWaterMarkR=1024 n=500000                   -0.89 %       ±5.44%  ±7.17%  ±9.20%
webstreams/pipe-to.js highWaterMarkW=1 highWaterMarkR=4096 n=500000                   -0.44 %       ±5.60%  ±7.38%  ±9.47%
webstreams/pipe-to.js highWaterMarkW=1024 highWaterMarkR=1 n=500000                   -0.40 %       ±5.26%  ±6.94%  ±8.90%
webstreams/pipe-to.js highWaterMarkW=1024 highWaterMarkR=1024 n=500000                -0.94 %       ±5.53%  ±7.29%  ±9.36%
webstreams/pipe-to.js highWaterMarkW=1024 highWaterMarkR=4096 n=500000                -1.55 %       ±5.31%  ±7.00%  ±8.98%
webstreams/pipe-to.js highWaterMarkW=4096 highWaterMarkR=1 n=500000                    1.35 %       ±5.36%  ±7.07%  ±9.07%
webstreams/pipe-to.js highWaterMarkW=4096 highWaterMarkR=1024 n=500000                 0.40 %       ±5.37%  ±7.08%  ±9.08%
webstreams/pipe-to.js highWaterMarkW=4096 highWaterMarkR=4096 n=500000                -1.26 %       ±5.47%  ±7.21%  ±9.25%
webstreams/readable-async-iterator.js type='bytes' n=100000                           -1.24 %      ±12.65% ±16.67% ±21.39%
webstreams/readable-async-iterator.js type='normal' n=100000                          -1.13 %       ±7.68% ±10.12% ±12.99%
webstreams/readable-read-buffered.js bufferSize=1 n=100000                             2.39 %       ±6.15%  ±8.10% ±10.40%
webstreams/readable-read-buffered.js bufferSize=10 n=100000                            0.32 %       ±6.31%  ±8.31% ±10.67%
webstreams/readable-read-buffered.js bufferSize=100 n=100000                          -0.86 %       ±6.21%  ±8.19% ±10.51%
webstreams/readable-read-buffered.js bufferSize=1000 n=100000                          0.39 %       ±6.18%  ±8.15% ±10.46%
webstreams/readable-read.js type='byob' n=100000                                      -0.01 %      ±12.69% ±16.73% ±21.47%
webstreams/readable-read.js type='normal' n=100000                                     0.61 %       ±5.30%  ±6.98%  ±8.96%
webstreams/tee.js type='bytes' n=100000                                               -2.50 %       ±9.08% ±11.97% ±15.36%
webstreams/tee.js type='normal' n=100000                                               0.04 %       ±5.77%  ±7.61%  ±9.76%
webstreams/writable-write.js type='await' n=100000                                    -2.18 %       ±6.02%  ±7.93% ±10.18%
webstreams/writable-write.js type='queued' n=100000                                    0.34 %       ±8.32% ±10.96% ±14.07%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 46 comparisons, you can thus
expect the following amount of false-positive results:
  2.30 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.46 false positives, when considering a   1% risk acceptance (**, ***),
  0.05 false positives, when considering a 0.1% risk acceptance (***)

[!WARNING]
Do not take GHA benchmark results as face value, always confirm them
using a dedicated machine, e.g. Jenkins CI.

nodejs-github-bot · 2026-10-07T08:39:12Z

CI: https://ci.nodejs.org/job/node-test-pull-request/78236/

nodejs-github-bot · 2026-10-11T07:28:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/78304/

A source without pull() has nothing observable left to do in its post-start step, since the started flag only gates calls into the pull algorithm. Set the flag right away instead of from a microtask, so a push-style ReadableStream allocates neither the closure nor the task and is not kept alive until the next microtask checkpoint. pipeTo and tee hold the only references to their reader and writer, so their [[closedPromise]] records are never observed as promises. Install the watchers as the records themselves, as pipeTo's ready hook already does, instead of materializing a promise plus reaction per side, and hand the erroring/release probes one shared pending promise. The tee's cancel promise is likewise materialized by the first branch cancel. Microtask ordering is unchanged: each hook enqueues its watcher at the position the promise reaction would have had. node benchmark/compare.js --runs 20 over benchmark/webstreams (46 rows, all others within the confidence interval): webstreams/creation.js kind='ReadableStream' *** +172.40% webstreams/creation.js kind='ReadableStream.tee' *** +20.47% webstreams/creation.js kind='ReadableStreamBYOBReader' *** +15.66% webstreams/creation.js kind='ReadableStreamDefaultReader' *** +14.53% webstreams/lifecycle.js kind='pipe-to' (40 runs) ** +10.98% Signed-off-by: Matteo Collina <hello@matteocollina.com> PR-URL: #66424 Reviewed-By: Paolo Insogna <paolo@cowtech.it> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: James M Snell <jasnell@gmail.com>

mcollina · 2026-10-13T08:11:11Z

Landed in 29bd740

nodejs-github-bot added needs-ci PRs that need a full CI run. web streams Issues and PRs related to the Web Streams API. labels Sep 30, 2026

mcollina marked this pull request as ready for review October 2, 2026 08:08

ShogunPanda approved these changes Oct 3, 2026

View reviewed changes

gurgunday approved these changes Oct 3, 2026

View reviewed changes

gurgunday added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. author ready PRs with CI started, the required approvals, and no outstanding review comments. labels Oct 3, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 3, 2026

mcollina added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 4, 2026

github-actions Bot added resume-ci-failed Resuming CI with the resume-ci label failed and requires manual intervention. and removed resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. labels Oct 4, 2026

jasnell approved these changes Oct 4, 2026

View reviewed changes

mcollina added request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. and removed resume-ci-failed Resuming CI with the resume-ci label failed and requires manual intervention. labels Oct 5, 2026

github-actions Bot removed the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Oct 6, 2026

mcollina force-pushed the webstream-perf-round21 branch from 56a3708 to 9605461 Compare October 6, 2026 17:29

ShogunPanda approved these changes Oct 7, 2026

View reviewed changes

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 7, 2026

aduh95 added author ready PRs with CI started, the required approvals, and no outstanding review comments. resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. labels Oct 7, 2026

github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Oct 7, 2026

sxa mentioned this pull request Oct 9, 2026

Windows/arm machines unavailable nodejs/build#4511

Open

mcollina mentioned this pull request Oct 10, 2026

stream: trim TransformStream construction costs #66643

Open

mcollina added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 11, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Oct 11, 2026

mcollina closed this Oct 13, 2026

Navigation Menu

Repository navigation

stream: skip idle webstreams start and watchers - #66424

stream: skip idle webstreams start and watchers#66424
mcollina wants to merge 1 commit into
nodejs:mainfrom
mcollina:webstream-perf-round21

mcollina commented Sep 30, 2026

Uh oh!

nodejs-github-bot commented Sep 30, 2026 •

edited by gurgunday

Loading

Uh oh!

codecov Bot commented Oct 2, 2026 •

edited

Loading

Uh oh!

gurgunday left a comment

Uh oh!

nodejs-github-bot commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 4, 2026

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

nodejs-github-bot commented Oct 7, 2026

Uh oh!

github-actions Bot commented Oct 7, 2026 •

edited

Loading

Uh oh!

nodejs-github-bot commented Oct 7, 2026

Uh oh!

nodejs-github-bot commented Oct 11, 2026

Uh oh!

mcollina commented Oct 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

mcollina commented Sep 30, 2026

No post-start microtask for sources without pull()

Closed watchers as records instead of promises

Tests

Benchmark

Uh oh!

nodejs-github-bot commented Sep 30, 2026 • edited by gurgunday Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Oct 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 4, 2026

Failed to resume CI

Uh oh!

github-actions Bot commented Oct 6, 2026

Uh oh!

nodejs-github-bot commented Oct 7, 2026

Uh oh!

github-actions Bot commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Oct 7, 2026

Uh oh!

nodejs-github-bot commented Oct 11, 2026

Uh oh!

mcollina commented Oct 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

No post-start microtask for sources without `pull()`

nodejs-github-bot commented Sep 30, 2026 •

edited by gurgunday

Loading

codecov Bot commented Oct 2, 2026 •

edited

Loading

github-actions Bot commented Oct 7, 2026 •

edited

Loading