Repository navigation
vfs: add ComposableProvider for layered mounts - #66235
Merged
Merged
Conversation
nodejs-github-bot
added
needs-ci
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66235 +/- ##
==========================================
- Coverage 90.30% 90.24% -0.06%
==========================================
Files 789 790 +1
Lines 272880 273298 +418
Branches 52110 52191 +81
==========================================
+ Hits 246418 246647 +229
- Misses 16912 17104 +192
+ Partials 9550 9547 -3
🚀 New features to boost your workflow:
|
Q16solver
added a commit
to Esposter/Esposter
that referenced
this pull request
Sep 24, 2026
…t model
vfs 0.5 ("align userland VFS mounts and fs hooks with Node.js") mounts the
way core node:vfs does: mount() takes no path and returns a mount point in a
reserved namespace under os.devNull, so a path is served by one VFS or by
the disk, never both. Core's docs give the reason — no mounted layer may
shadow a real directory — and say VFS is no security boundary.
- FsProvider.mount() returns the mount point; the overlay option goes (0.5
calls it shim-only, core has none), so the node:vfs swap stays one file.
- runNodeInProcess no longer mounts: it mounted an empty overlay at the cwd
and never wrote into it, so every read and write already went to disk.
- The provider tests address files under the returned mount point and pin
that a mounted provider never shadows a real path.
- The vfs hold in renovate.json is dropped; docs describe the mount model and
core's open layered-mount work (nodejs/node#66235) as the path to a RAM
overlay of the cwd.
- staleNames: two identifiers the dependency skill cited that no longer exist.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_019dwem6ZLsMCyc52v9UbhFV
jasnell
reviewed
Sep 24, 2026
| } | ||
|
|
||
| // Providers are ordered from highest priority (and write target) to lowest. | ||
| // Removing a file records a whiteout so a lower copy cannot reappear. |
Member
There was a problem hiding this comment.
Nit: a bit more comment detail on the expected semantics would be helpful but non-blocking.
jasnell
approved these changes
Sep 24, 2026
ShogunPanda
approved these changes
Sep 24, 2026
Allow providers to be layered at one mount point. Reads search layers in priority order, while writes copy lower-layer files to the first provider and deletions hide lower copies without changing them. Assisted-by: pi Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
force-pushed
the
vfs-composable-provider
branch
from
September 24, 2026 21:55
8a659db to
11be3bd
Compare
ShogunPanda
approved these changes
Oct 2, 2026
mcollina
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
mcollina
added
the
resume-ci
github-actions
Bot
removed
the
resume-ci
Collaborator
mcollina
added
the
commit-queue
Collaborator
|
Landed in ad55417 |
nodejs-github-bot
removed
the
commit-queue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow providers to be layered at one mount point. Reads search layers in priority order, while writes copy lower-layer files to the first provider and deletions hide lower copies without changing them.
AI gen, reviewed by me.