Skip to content

Conversation

@bengl
Copy link
Member

@bengl bengl commented May 6, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

For consistency with other docs, show v8 functions as being on the v8
object.

For consistency with other docs, show v8 functions as being on the v8
object.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 6, 2016
@mscdex mscdex added the v8 engine Issues and PRs related to the V8 dependency. label May 6, 2016
@bnoordhuis
Copy link
Member

LGTM

4 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented May 6, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented May 6, 2016

LGTM

@targos
Copy link
Member

targos commented May 6, 2016

LGTM

@Qard
Copy link
Member

Qard commented May 6, 2016

LGTM

targos pushed a commit that referenced this pull request May 9, 2016
For consistency with other docs, show v8 functions as being on the v8
object.

PR-URL: #6615
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
@targos
Copy link
Member

targos commented May 9, 2016

landed in 95d0fee

@targos targos closed this May 9, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
For consistency with other docs, show v8 functions as being on the v8
object.

PR-URL: #6615
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants