-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add tests for stream3 buffering using cork #6493
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev
Previous commit
test: add streams3 cork then end test
- Loading branch information
commit f0fe6962899b6ed83fc4bbd480c763285e3aa00d
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
'use strict'; | ||
require('../common'); | ||
const assert = require('assert'); | ||
const stream = require('stream'); | ||
const Writable = stream.Writable; | ||
|
||
// Test the buffering behaviour of Writable streams. | ||
// | ||
// The call to cork() triggers storing chunks which are flushed | ||
// on calling end() and the stream subsequently ended. | ||
// | ||
// node version target: 0.12 | ||
|
||
const expectedChunks = ['please', 'buffer', 'me', 'kindly']; | ||
var inputChunks = expectedChunks.slice(0); | ||
var seenChunks = []; | ||
var seenEnd = false; | ||
|
||
var w = new Writable(); | ||
// lets arrange to store the chunks | ||
w._write = function(chunk, encoding, cb) { | ||
// stream end event is not seen before the last write | ||
assert.ok(!seenEnd); | ||
// default encoding given none was specified | ||
assert.equal(encoding, 'buffer'); | ||
|
||
seenChunks.push(chunk); | ||
cb(); | ||
}; | ||
// lets record the stream end event | ||
w.on('finish', () => { | ||
seenEnd = true; | ||
}); | ||
|
||
function writeChunks(remainingChunks, callback) { | ||
var writeChunk = remainingChunks.shift(); | ||
var writeState; | ||
|
||
if (writeChunk) { | ||
setImmediate(() => { | ||
writeState = w.write(writeChunk); | ||
// we were not told to stop writing | ||
assert.ok(writeState); | ||
|
||
writeChunks(remainingChunks, callback); | ||
}); | ||
} else { | ||
callback(); | ||
} | ||
} | ||
|
||
// do an initial write | ||
w.write('stuff'); | ||
// the write was immediate | ||
assert.equal(seenChunks.length, 1); | ||
// reset the seen chunks | ||
seenChunks = []; | ||
|
||
// trigger stream buffering | ||
w.cork(); | ||
|
||
// write the bufferedChunks | ||
writeChunks(inputChunks, () => { | ||
// should not have seen anything yet | ||
assert.equal(seenChunks.length, 0); | ||
|
||
// trigger flush and ending the stream | ||
w.end(); | ||
|
||
// stream should not ended in current tick | ||
assert.ok(!seenEnd); | ||
|
||
// buffered bytes should be seen in current tick | ||
assert.equal(seenChunks.length, 4); | ||
|
||
// did the chunks match | ||
for (var i = 0, l = expectedChunks.length; i < l; i++) { | ||
var seen = seenChunks[i]; | ||
// there was a chunk | ||
assert.ok(seen); | ||
|
||
var expected = new Buffer(expectedChunks[i]); | ||
// it was what we expected | ||
assert.ok(seen.equals(expected)); | ||
} | ||
|
||
setImmediate(() => { | ||
// stream should have ended in next tick | ||
assert.ok(seenEnd); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Buffer.from(expectedChunks[i])