cli: allow unary-negated eval arguments#61962
Open
jorgitin02 wants to merge 1 commit intonodejs:mainfrom
Open
Conversation
Fixes: nodejs#43397 Signed-off-by: jorge guerrero <grrr.jrg@gmail.com>
Collaborator
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61962 +/- ##
==========================================
+ Coverage 88.84% 89.73% +0.89%
==========================================
Files 674 672 -2
Lines 204957 204545 -412
Branches 39309 39276 -33
==========================================
+ Hits 182087 183557 +1470
+ Misses 15088 13306 -1782
+ Partials 7782 7682 -100
🚀 New features to boost your workflow:
|
addaleax
requested changes
Feb 24, 2026
Member
addaleax
left a comment
There was a problem hiding this comment.
From the ticket:
For users who prefer setting mandatory option arguments rather than positional arguments, node --print --eval=-42 already works. :)
I think that's the right solution here. Adding behavior that depends on the specific text passed to the flag is going to be dangerous; now you cannot know anymore whether node -e -<text> will work or throw, it's going to depend on the specific value of text (i.e. the behavior is less consistent now, not more).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #43397
Summary
-42,-0,-NaN) instead of missing option args-e -pstill reports missing eval argumenttest/parallel/test-cli-eval.jsfor unary-negation and nearby safety pathsTesting