Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade to V8 4.9.385.35 #6077

Merged
merged 2 commits into from
Apr 7, 2016
Merged

deps: upgrade to V8 4.9.385.35 #6077

merged 2 commits into from
Apr 7, 2016

Conversation

bnoordhuis
Copy link
Member

R=@nodejs/v8

I threw in the build: remove -f{data,function}-sections flags commit because otherwise I'd have to rebuild twice. :-) See #6056 for background.

CI: https://ci.nodejs.org/job/node-test-pull-request/2173/

@bnoordhuis bnoordhuis added the v8 engine Issues and PRs related to the V8 dependency. label Apr 6, 2016
@trevnorris
Copy link
Contributor

LGTM

@bnoordhuis
deps: upgrade to V8 4.9.385.35
3a8e823 
PR-URL: nodejs#6077
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
build: remove -f{data,function}-sections flags
71544c5 
We don't link with `--gc-sections` because it's unreliable with some
toolchains, so all these flags do is make the compiler generate slightly
worse code.  Drop them.

Refs: nodejs#6056
PR-URL: nodejs#6077
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis bnoordhuis closed this Apr 7, 2016
@bnoordhuis bnoordhuis deleted the upgrade-v8 branch April 7, 2016 11:16
@bnoordhuis bnoordhuis merged commit 71544c5 into nodejs:master Apr 7, 2016
@MylesBorins MylesBorins mentioned this pull request Apr 11, 2016
Closed
@MylesBorins
Copy link
Contributor

@bnoordhuis safe to assume this does not make sense for lts?

@bnoordhuis
Copy link
Member Author

71544c5 could be cherry-picked but it's not critical.

@MylesBorins
Copy link
Contributor

@bnoordhuis this is not landing cleanly on v5.x would you be able to backport so we can include this in 5.10.2

MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
@bnoordhuis
build: remove -f{data,function}-sections flags
b8649e3 
We don't link with `--gc-sections` because it's unreliable with some
toolchains, so all these flags do is make the compiler generate slightly
worse code.  Drop them.

Refs: #6056
PR-URL: #6077
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@bnoordhuis
Copy link
Member Author

@thealphanerd When you say 'this', do you mean the V8 upgrade or the other commit?

@MylesBorins
Copy link
Contributor

The v8 upgrade. The other commit landed without problem

@bnoordhuis
Copy link
Member Author

The V8 upgrade shouldn't go into v4 or v5. There are perhaps some individual fixes we could cherry-pick.

MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@bnoordhuis
build: remove -f{data,function}-sections flags
8952330 
We don't link with `--gc-sections` because it's unreliable with some
toolchains, so all these flags do is make the compiler generate slightly
worse code.  Drop them.

Refs: #6056
PR-URL: #6077
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@bnoordhuis
build: remove -f{data,function}-sections flags
a5f8d0c 
We don't link with `--gc-sections` because it's unreliable with some
toolchains, so all these flags do is make the compiler generate slightly
worse code.  Drop them.

Refs: #6056
PR-URL: #6077
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
This was referenced Apr 21, 2016
Closed
Closed
@MylesBorins
Copy link
Contributor

@bnoordhuis if you think any parts of this should be backported to v4.x-staging could you please open a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnoordhuis @trevnorris @MylesBorins