Conversation
|
Review requested:
|
|
cc: @nodejs/tsc since it’s an end-of-life deprecation |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60658 +/- ##
==========================================
+ Coverage 88.90% 89.78% +0.88%
==========================================
Files 672 670 -2
Lines 203809 203786 -23
Branches 39097 39181 +84
==========================================
+ Hits 181197 182977 +1780
+ Misses 14897 13132 -1765
+ Partials 7715 7677 -38
🚀 New features to boost your workflow:
|
|
cc @nodejs/crypto @nodejs/net |
|
It looks flaky in GitHub Actions CI. Could someone rerun it, please? |
|
Should I do a rebase to see if it’s still failing? |
That wouldn't help (unless a fix for the flakiness had landed on main since last commit, but AFAIK that's not the case), and force us to re-review and re-run all CI jobs |
Commit Queue failed- Loading data for nodejs/node/pull/60658 ✔ Done loading data for nodejs/node/pull/60658 ----------------------------------- PR info ------------------------------------ Title tls: move _tls_* to end-of-life (#60658) Author Sebastian Beltran <bjohansebas@gmail.com> (@bjohansebas) Branch bjohansebas:tls_eol -> nodejs:main Labels tls, c++, semver-major, author ready, deprecations, needs-ci, needs-citgm Commits 1 - tls: move _tls_* to end-of-life Committers 1 - GitHub <noreply@github.com> PR-URL: https://github.com/nodejs/node/pull/60658 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/60658 Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 09 Nov 2025 21:40:41 GMT ✔ Approvals: 2 ✔ - Tim Perry (@pimterry): https://github.com/nodejs/node/pull/60658#pullrequestreview-3597808519 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/60658#pullrequestreview-3613841924 ✘ semver-major requires at least 2 TSC approvals ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-12-20T16:15:00Z: https://ci.nodejs.org/job/node-test-pull-request/70556/ - Querying data for job/node-test-pull-request/70556/ ✔ Build data downloaded ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/21187285768 |
|
Note that these weren't runtime-deprecated in 24, only in 25. |
So that in Node.js 26 these modules are no longer there, and are now internal to Node.js only instead of public.