http: move writeHeader to end-of-life #60635
Open
+4
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http
bjohansebas
force-pushed
the
writeHeader-eol
branch
from
2c32975 to
c798da4
Compare
bjohansebas
added
the
semver-major
Member
Author
|
cc: @nodejs/tsc |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60635 +/- ##
==========================================
- Coverage 88.54% 88.54% -0.01%
==========================================
Files 703 703
Lines 208077 208072 -5
Branches 40082 40089 +7
==========================================
- Hits 184252 184246 -6
+ Misses 15848 15845 -3
- Partials 7977 7981 +4
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Nov 8, 2025
bjohansebas
added
needs-citgm
github-actions
bot
removed
the
request-ci
Collaborator
lpinca
approved these changes
Nov 8, 2025
marco-ippolito
approved these changes
Nov 9, 2025
Member
|
There is a problem with the docs linter I think. Can you fix? |
bjohansebas
force-pushed
the
writeHeader-eol
branch
from
c798da4 to
ff0e79d
Compare
Member
Author
|
Yes, it was already fixed in #60636, I just did a rebase |
RafaelGSS
approved these changes
Nov 9, 2025
github-actions
bot
removed
the
request-ci
Collaborator
bjohansebas
added
the
author ready
jasnell
approved these changes
Nov 9, 2025
Ethan-Arrowood
approved these changes
Nov 10, 2025
github-actions
bot
removed
the
request-ci
Collaborator
tniessen
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been over 7 years since it was deprecated in documentation only, and it’s been runtime-deprecated since version 25. I think it can finally be moved to end-of-life for version 26, since its usage is practically nonexistent.