-
-
Notifications
You must be signed in to change notification settings - Fork 33.8k
meta: call create-release-post.yml post release
#60366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+53
−51
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
642106f
meta: call `create-release-post.yml` post release
avivkeller debfa58
Update post-release.yml
avivkeller 47c1c7b
fixup!
avivkeller 9f41de9
fixup!
avivkeller 1b1a358
fixup!
avivkeller 2f97590
fixup!
avivkeller 0f346f9
fixup!
avivkeller File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| name: Post-Release actions | ||
|
|
||
| on: | ||
| workflow_dispatch: | ||
| inputs: | ||
| version: | ||
| description: The version to generate a blog post for. | ||
| type: string | ||
| required: true | ||
| release: | ||
| types: [released] | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| post-release-actions: | ||
| if: github.repository == 'nodejs/node' | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Trigger update-links workflow on nodejs/release-cloudflare-worker | ||
| run: | | ||
| gh workflow run update-links.yml --repo nodejs/release-cloudflare-worker | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }} | ||
|
|
||
| - name: Trigger create-release-post workflow on nodejs/nodejs.org | ||
| run: | | ||
| gh workflow run create-release-post.yml --repo nodejs/nodejs.org -f version=$VERSION | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GH_USER_TOKEN }} | ||
| VERSION: ${{ inputs.version || github.event.release.tag_name }} | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,8 +30,8 @@ official release builds for Node.js, hosted on <https://nodejs.org/>. | |
| * [14. Push the release tag](#14-push-the-release-tag) | ||
| * [15. Promote and sign the release builds](#15-promote-and-sign-the-release-builds) | ||
| * [16. Check the release](#16-check-the-release) | ||
| * [17. Create a blog post](#17-create-a-blog-post) | ||
| * [18. Create the release on GitHub](#18-create-the-release-on-github) | ||
| * [17. Create the release on GitHub](#17-create-the-release-on-github) | ||
| * [18. Create a blog post](#18-create-a-blog-post) | ||
| * [19. Announce](#19-announce) | ||
| * [20. Celebrate](#20-celebrate) | ||
| * [LTS releases](#lts-releases) | ||
|
|
@@ -1069,21 +1069,31 @@ have the right internal version strings. Check that the API docs are available | |
| at <https://nodejs.org/api/>. Check that the release catalog files are correct | ||
| at <https://nodejs.org/dist/index.tab> and <https://nodejs.org/dist/index.json>. | ||
|
|
||
| ### 17. Create a blog post | ||
| ### 17. Create the release on GitHub | ||
|
|
||
| * Go to the [New release page](https://github.com/nodejs/node/releases/new). | ||
| * Select the tag version you pushed earlier. | ||
| * For release title, copy the title from the changelog. | ||
| * For the description, copy the rest of the changelog entry. | ||
| * If you are not releasing the latest "Current", uncheck | ||
| "Set as the latest release". | ||
| * Click on the "Publish release" button. | ||
|
|
||
| ### 18. Create a blog post | ||
|
|
||
| There is an automatic build that is kicked off when you promote new builds, so | ||
| within a few minutes nodejs.org will be listing your new version as the latest | ||
| release. However, the blog post is not yet fully automatic. | ||
| release, and a blog post draft PR will be created. | ||
|
|
||
| Create a new blog post by running the [nodejs.org release-post.js script][]: | ||
| In the event that a draft PR _is not created_, the [`scripts:release-post`][] script | ||
| can be used as an alternative: | ||
|
|
||
| ```bash | ||
| node ./apps/site/scripts/release-post/index.mjs x.y.z | ||
| # In the apps/site folder of nodejs/nodejs.org | ||
| node --run scripts:release-post x.y.z | ||
| ``` | ||
|
|
||
| This script will use the promoted builds and changelog to generate the post. Run | ||
| `npm run serve` to preview the post locally before pushing to the | ||
| [nodejs.org repository][]. | ||
| This script will use the promoted builds and changelog to generate the post. | ||
|
|
||
| * You can add a short blurb just under the main heading if you want to say | ||
| something important, otherwise the text should be publication ready. | ||
|
|
@@ -1098,33 +1108,13 @@ This script will use the promoted builds and changelog to generate the post. Run | |
| to reflect those changes. | ||
|
|
||
| * Always use pull-requests on the [nodejs.org repository][]. Be respectful | ||
| of the website team, but you do not have to wait for PR sign-off. Please | ||
| use the following commit message format: | ||
|
|
||
| ```console | ||
| Blog: vX.Y.Z release post | ||
|
|
||
| Refs: <full URL to your release proposal PR> | ||
| ``` | ||
|
|
||
| * In order to trigger the CI Checks of the [nodejs.org repository][]; Please | ||
| attach the `github_actions:pull-request` label to the PR. | ||
avivkeller marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| of the website team, but you do not have to wait for PR sign-off. | ||
|
|
||
| * Changes to the base branch, `main`, on the [nodejs.org repository][] will | ||
| trigger a new build of nodejs.org, so your changes should appear a few minutes | ||
| after pushing. You can follow the [Deployments](https://github.com/nodejs/nodejs.org/deployments) page | ||
| to see when the build finishes and gets published. | ||
|
|
||
| ### 18. Create the release on GitHub | ||
|
|
||
| * Go to the [New release page](https://github.com/nodejs/node/releases/new). | ||
| * Select the tag version you pushed earlier. | ||
| * For release title, copy the title from the changelog. | ||
| * For the description, copy the rest of the changelog entry. | ||
| * If you are not releasing the latest "Current", uncheck | ||
| "Set as the latest release". | ||
| * Click on the "Publish release" button. | ||
|
|
||
| ### 19. Announce | ||
|
|
||
| The nodejs.org website will automatically rebuild and include the new version. | ||
|
|
@@ -1491,7 +1481,7 @@ Typical resolution: sign the release again. | |
| [Node.js Snap management repository]: https://github.com/nodejs/snap | ||
| [Snap]: https://snapcraft.io/node | ||
| [`create-release-proposal`]: https://github.com/nodejs/node/actions/workflows/create-release-proposal.yml | ||
| [`scripts:release-post`]: https://github.com/nodejs/nodejs.org/blob/HEAD/apps/site/scripts/release-post/index.mjs | ||
| [build-infra team]: https://github.com/orgs/nodejs/teams/build-infra | ||
| [expected assets]: https://github.com/nodejs/build/tree/HEAD/ansible/www-standalone/tools/promote/expected_assets | ||
| [nodejs.org release-post.js script]: https://github.com/nodejs/nodejs.org/blob/HEAD/apps/site/scripts/release-post/index.mjs | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. non-blocking nit: this script is still mentioned as a fallback - perhaps it should remain? |
||
| [nodejs.org repository]: https://github.com/nodejs/nodejs.org | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.