src: fix broken fast callback signatures#59600
Closed
Renegade334 wants to merge 4 commits intonodejs:mainfrom
Closed
src: fix broken fast callback signatures#59600Renegade334 wants to merge 4 commits intonodejs:mainfrom
Renegade334 wants to merge 4 commits intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
Renegade334
commented
Aug 23, 2025
Comment on lines
-190
to
-194
| if (value < 1) { | ||
| HandleScope scope(options.isolate); | ||
| THROW_ERR_OUT_OF_RANGE(options.isolate, "value is out of range"); | ||
| return; | ||
| } |
Member
Author
There was a problem hiding this comment.
value is validated in the JS layer, so an assertion should be fine here.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #59600 +/- ##
==========================================
+ Coverage 89.83% 89.87% +0.04%
==========================================
Files 667 667
Lines 196062 196059 -3
Branches 38501 38501
==========================================
+ Hits 176133 176217 +84
+ Misses 12397 12287 -110
- Partials 7532 7555 +23
🚀 New features to boost your workflow:
|
anonrig
approved these changes
Aug 25, 2025
addaleax
approved these changes
Aug 28, 2025
addaleax
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
Collaborator
Collaborator
Member
Author
|
This should be ready for CQ. |
addaleax
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in f5e2ecc...8ca5fec |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
PR-URL: #59600 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
PR-URL: #59600 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
PR-URL: #59600 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
PR-URL: #59600 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
PR-URL: #59600 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
PR-URL: #59600 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
PR-URL: #59600 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
PR-URL: #59600 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95
pushed a commit
that referenced
this pull request
Oct 22, 2025
PR-URL: #59600 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95
pushed a commit
that referenced
this pull request
Oct 22, 2025
PR-URL: #59600 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95
pushed a commit
that referenced
this pull request
Oct 22, 2025
PR-URL: #59600 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-submitting #59055 for visibility, as the last PR went six weeks without any reviews.
Since #54408, the various fast callbacks that were edited by that PR have broken signatures and have not been invoked. (The changed signatures would only have been valid if the receiver were prepended to the function arguments wherever those bindings were called from JS, which isn't the case.)
There was no debug tracking of these callbacks, so this went unnoticed at the time.
This change fixes the broken signatures and adds debug testing to validate the fast paths.
This effectively reverts the remaining source changes from #54408 that were not already covered by #58054.