-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
doc,test: add documentation and test on how to use addons in SEA #59582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Review requested:
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #59582 +/- ##
==========================================
- Coverage 88.53% 88.52% -0.01%
==========================================
Files 703 703
Lines 208077 208220 +143
Branches 40083 40136 +53
==========================================
+ Hits 184214 184326 +112
- Misses 15881 15903 +22
- Partials 7982 7991 +9 🚀 New features to boost your workflow:
|
|
Formatted the addon code and changed the test to use |
|
Forgot the |
|
Forgot to skip on ppc64le like what's done in #59563, added |
|
For some reason, this doesn't actually work on Linux arm64 - but only in the GitHub actions, and x64 Linux seems to work alright in GitHub actions, and in the Jenkins CI, both work alright. |
c434441 to
24e02c1
Compare
|
I poked at it a bit and it looks like the failure in the github actions on linux arm64 is a legit bug of postject - which only reproduces in a Linux arm64 container, but not on bare metal, or Linux x64. Opened nodejs/postject#105 |
a716236 to
f08434e
Compare
f08434e to
9a73fa3
Compare
This comment has been minimized.
This comment has been minimized.
|
Landed in 61cf89c |
Fixes: #60611