Skip to content

Conversation

@joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Aug 22, 2025

Fixes: #60611

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/single-executable

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Aug 22, 2025
@codecov
Copy link

codecov bot commented Aug 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.52%. Comparing base (d137969) to head (84ed79b).
⚠️ Report is 66 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #59582      +/-   ##
==========================================
- Coverage   88.53%   88.52%   -0.01%     
==========================================
  Files         703      703              
  Lines      208077   208220     +143     
  Branches    40083    40136      +53     
==========================================
+ Hits       184214   184326     +112     
- Misses      15881    15903      +22     
- Partials     7982     7991       +9     

see 37 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joyeecheung
Copy link
Member Author

Formatted the addon code and changed the test to use cwd: tmpdir.path for the SEA since the testing environment does not allow access to os.tmpdir().

@nodejs-github-bot
Copy link
Collaborator

@joyeecheung
Copy link
Member Author

Forgot the skipIfSingleExecutableIsNotSupported() call, added.

@joyeecheung
Copy link
Member Author

Forgot to skip on ppc64le like what's done in #59563, added

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@joyeecheung
Copy link
Member Author

For some reason, this doesn't actually work on Linux arm64 - but only in the GitHub actions, and x64 Linux seems to work alright in GitHub actions, and in the Jenkins CI, both work alright.

[process 202296]: --- stderr ---
/home/runner/work/node/node/node/test/.tmp.4536/sea: symbol lookup error: /home/runner/work/node/node/node/test/.tmp.4536/hello.node: undefined symbol: napi_define_properties

[process 202296]: --- stdout ---

[process 202296]: status = 127, signal = null
/home/runner/work/node/node/node/test/common/child_process.js:98
    throw error;
    ^

Error: - process terminated with status 127, expected 0

@joyeecheung
Copy link
Member Author

I poked at it a bit and it looks like the failure in the github actions on linux arm64 is a legit bug of postject - which only reproduces in a Linux arm64 container, but not on bare metal, or Linux x64. Opened nodejs/postject#105

@joyeecheung joyeecheung force-pushed the test-sea-addon branch 2 times, most recently from a716236 to f08434e Compare November 8, 2025 20:32
@nodejs-github-bot
Copy link
Collaborator

@killghost

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@legendecas legendecas added test Issues and PRs related to the tests. node-api Issues and PRs related to the Node-API. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. single-executable Issues and PRs related to single-executable applications labels Nov 13, 2025
@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 13, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@legendecas legendecas added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 17, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 17, 2025
@nodejs-github-bot nodejs-github-bot merged commit 61cf89c into nodejs:main Nov 17, 2025
86 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 61cf89c

@github-project-automation github-project-automation bot moved this from Need Triage to Done in Node-API Team Project Nov 17, 2025
targos pushed a commit that referenced this pull request Nov 27, 2025
PR-URL: #59582
Fixes: #60611
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. node-api Issues and PRs related to the Node-API. single-executable Issues and PRs related to single-executable applications test Issues and PRs related to the tests.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Does SAE (Single Executable Packaging) for Node.js Support Loading Addons? Thanks

8 participants