[v22.x backport] Wasm ESM Integration PRs & Unflagging #59179
+263
−66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
guybedford
force-pushed
the
esm-integration-unflag-backport
branch
from
b6d4790 to
8a5a312
Compare
guybedford
changed the title
guybedford
force-pushed
the
esm-integration-unflag-backport
branch
from
8a5a312 to
d069903
Compare
guybedford
force-pushed
the
esm-integration-unflag-backport
branch
from
d069903 to
d5ff7ea
Compare
|
This is the first PR to run after re-enabling OSX testing. |
|
Could you please rebase? Also, #59020 is labeled
dont-land-on-v22.x
|
guybedford
force-pushed
the
esm-integration-unflag-backport
branch
from
d5ff7ea to
fc09828
Compare
|
@aduh95 sure, this is now rebased. I initially added that label when I thought string builtins was not implementable, but it was trivial to include the polyfill. Aligning the semantics for instances between 22 and 24 feels like a win to me here, so I think it could be worthwhile. |
guybedford
force-pushed
the
esm-integration-unflag-backport
branch
from
fc09828 to
cb08197
Compare
|
It actually turns out we can use the V8 flag here instead of including the polyfill for string builtins, so rebasing #59020 was actually much easier than I originally implemented too. |
guybedford
force-pushed
the
esm-integration-unflag-backport
branch
from
cb08197 to
c25ba79
Compare
This comment was marked as outdated.
This comment was marked as outdated.
guybedford
force-pushed
the
esm-integration-unflag-backport
branch
from
c25ba79 to
208e26d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
guybedford
force-pushed
the
esm-integration-unflag-backport
branch
from
208e26d to
a9736da
Compare
PR-URL: nodejs#59020 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
guybedford
force-pushed
the
esm-integration-unflag-backport
branch
2 times, most recently
from
b2ebc0d to
d6de6cd
Compare
PR-URL: nodejs#57038 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
guybedford
force-pushed
the
esm-integration-unflag-backport
branch
from
d6de6cd to
6f42a72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports:
This does not include source phase imports support as this was a later v8 feature.
This only reflects the unflagging of the experimental instance phase, and the backport is updated to reflect that.
JS String Builtins is possible to support with a very small polyfill layer allowing the implementation to match and pass the tests from v24.